Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version from 2021-04-01 to 2022-09-01 for resources module #25049

Closed
meghanagupta95 opened this issue Jan 4, 2023 · 9 comments · Fixed by #25434
Closed

Update API version from 2021-04-01 to 2022-09-01 for resources module #25049

meghanagupta95 opened this issue Jan 4, 2023 · 9 comments · Fixed by #25434
Assignees
Labels
ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group Azure CLI Team The command of the issue is owned by Azure CLI team feature-request

Comments

@meghanagupta95
Copy link
Member

Related command

No response

Resource Provider

Microsoft.Resources/resources

Description of Feature or Work Requested

We need to update the API version from 2021-04-01 to 2022-09-01 for the resources module. The Swagger changes have been merged in Azure/azure-rest-api-specs#21203.

Minimum API Version Required

2022-09-01

Swagger PR link / SDK link

Azure/azure-rest-api-specs#21203

Request Example

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2022-09-01/examples/PutTagsSubscription.json, https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2022-09-01/examples/PatchTagsSubscription.json, https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2022-09-01/examples/DeleteTagsSubscription.json, https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2022-09-01/examples/PutTagsResource.json, https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2022-09-01/examples/PatchTagsResource.json, https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2022-09-01/examples/DeleteTagsResource.json

Target Date

01-31-2022

Additional context

No response

@yonzhan yonzhan added ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group Azure CLI Team The command of the issue is owned by Azure CLI team labels Jan 4, 2023
@yonzhan yonzhan added this to the Jan 2023 (2023-02-07) milestone Jan 4, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 4, 2023

update API for resources

@zhoxing-ms
Copy link
Contributor

@meghanagupta95 I'd like to confirm with you whether we only need to upgrade the api-version, or we also need to support some new commands and parameters? I see that in Request Example , there are some examples related to tag, does this need us to update the tag related commands?

@meghanagupta95
Copy link
Member Author

@zhoxing-ms the new API version introduces a new HTTP response code of 202 for existing tags PUT/PATCH/DELETE operations (The examples are related to these pre-existing tags commands.) I don't think that should qualify as a new command or parameter, but please correct me if I'm wrong?

@zhoxing-ms
Copy link
Contributor

the new API version introduces a new HTTP response code of 202 for existing tags PUT/PATCH/DELETE operations (The examples are related to these pre-existing tags commands.

@meghanagupta95 Yes, they do not generate new commands and parameters. So you don't need us to add new commands and parameters, right?

@meghanagupta95
Copy link
Member Author

@zhoxing-ms No, it is not needed.

@zhoxing-ms
Copy link
Contributor

@meghanagupta95 Sorry, I have to tell you that there are risks in completing the bumping version of Microsoft.Resources in this sprint. The main reasons for the risk are as follows:

  1. The bumping version for RP Microsoft.Resources affects too many modules, and 850 files need to be re-recorded. Unfortunately, other modules are also doing the bumping version, resulting in a large number of conflicts in PR.
  2. The bumping version pipeline we used recently is being upgraded, this leads to more time than usual to create PR.
  3. Our Chinese team has just experienced a long Chinese Spring Festival holiday, so some works were interrupted during the holiday.

So I'd like to confirm with you in advance whether this feature request is very urgent? Could you accept that we plan to postpone it's release to the next sprint (03-07)? Before that, we can provide the private package through edge build to let customers with urgent needs use it in advance.
If this feature request is really very urgent and important, I will consider completing it in time through working overtime in the last few days

@meghanagupta95
Copy link
Member Author

Hi @zhoxing-ms, to clarify, do you mean the changes will be out by 03-07? That should be fine.

@zhoxing-ms
Copy link
Contributor

do you mean the changes will be out by 03-07? That should be fine.

@meghanagupta95 Yes, we will release it in 03-07, thanks for your understanding~

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 16, 2023

@meghanagupta95 since we have some urgent security related feature to deal with in this sprint and this resource version bump needs more time to collaborate with other module owners and test, we have to postpone this to the next sprint (04-04). Sorry for the inconvenience caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM az resource/group/lock/tag/deployment/policy/managementapp/account management-group Azure CLI Team The command of the issue is owned by Azure CLI team feature-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants