Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: simplify comparison to satisfy linter #629

Merged
merged 1 commit into from
Mar 2, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Mar 2, 2019

Reason for Change:

Fixes a make test-style problem that somehow crept in with #627, at least for me. It also fails inside make dev, so I assume this will be a problem for CI in general:

==> Running static validations and linters <==
pkg/api/types_test.go:852:5: should omit comparison to bool constant, can be simplified to !update (megacheck.{unused,gosimple})
	if update != true {
	   ^
Makefile:126: recipe for target 'test-style' failed
make: *** [test-style] Error 1

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #629 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files          91       91           
  Lines       13947    13947           
=======================================
  Hits         8901     8901           
  Misses       4375     4375           
  Partials      671      671

Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890 tariq1890 merged commit 4730e05 into Azure:master Mar 2, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
@mboersma mboersma deleted the linter-fix branch June 21, 2019 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants