Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: DRY_RUN variable is a string not a bool #601

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Feb 27, 2019

Reason for Change:

Azure pipelines treats the variable DRY_RUN as a string (did not find a way to specify it as a bool), so using string comparison. Previously not('False') was evaluating as False.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #601 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage    56.7%   56.68%   -0.02%     
==========================================
  Files          91       91              
  Lines       13898    13902       +4     
==========================================
  Hits         7881     7881              
- Misses       5352     5355       +3     
- Partials      665      666       +1

@jackfrancis
Copy link
Member

/lgtm

@CecileRobertMichon
Copy link
Contributor Author

Need to validate

/hold

@acs-bot acs-bot removed the lgtm label Feb 27, 2019
@CecileRobertMichon
Copy link
Contributor Author

This is ready. The VHD pipeline failed because our SA delete requests are being throttled (I was doing some heavy manual clean-up in the background at the same time) but skipping/not skipping the classic SA copy works as expected.

/hold cancel

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Feb 27, 2019
@jackfrancis jackfrancis merged commit 29498d7 into Azure:master Feb 27, 2019
@acs-bot
Copy link

acs-bot commented Feb 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
@CecileRobertMichon CecileRobertMichon deleted the fix-dry-run-bool branch April 18, 2019 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants