This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
ci: add storage account cleanup to VHD pipeline #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.pipelines/vhd-builder.yaml
Outdated
| @@ -44,6 +44,19 @@ phases: | |||
| -e VHD_NAME=${VHD_NAME} \ | |||
| ${DEIS_GO_DEV_IMAGE} make az-copy | |||
| displayName: Copying resource to Classic Storage Account | |||
| condition: not(variables['DRY_RUN']) | |||
There was a problem hiding this comment.
this ensures we only copy the disk to a classic storage account if DRY_RUN is set to False (True by default). That way, we won't clutter the classic SA for PR builds.
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 91 91
Lines 13871 13871
=======================================
Hits 7871 7871
Misses 5336 5336
Partials 664 664 |
CecileRobertMichon
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add cleanup to VHD pipeline to avoid running out of quota.
Issue Fixed:
Requirements:
Notes: