This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: Multiple SSH keys for Linux & Windows nodes #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
/assign @tariq1890 |
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 56.74% 56.78% +0.04%
==========================================
Files 91 91
Lines 13870 13894 +24
==========================================
+ Hits 7870 7890 +20
- Misses 5336 5338 +2
- Partials 664 666 +2 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PatrickLang, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
added a commit
that referenced
this pull request
Feb 26, 2019
This reverts commit bbcfb2b.
jackfrancis
added a commit
that referenced
this pull request
Feb 26, 2019
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
* Supporting multiple SSH keys on Linux & Windows * Updating docs
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
I'd like to use this to add extra single-use SSH keys for the purposes of log collection during Kubernetes upstream test passes. My workflow will be:
This ensures that my personal private key is never stored on a test automation machine, but I can still use it to connect to machines to debug test passes. I can also disable password login on all machines. There's little risk of the private key from step 1 being leaked because it's never used outside that one test pass.
Issue Fixed:
Fixes #515
Requirements: