Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Explicitly use overlay2 storage driver while creation of vhd, by defa… #574

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Conversation

awesomenix
Copy link
Contributor

…ult docker uses aufs

Reason for Change:

By default docker uses aufs storage driver, hence while creation of vhd, the container images are always downloaded to wrong partition /var/lib/docker/aufs while we start docker with overlay2 storage driver after creation of vm. Configure docker engine to use overlay2 after installation during vhd creation.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #574 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #574   +/-   ##
=======================================
  Coverage   56.74%   56.74%           
=======================================
  Files          91       91           
  Lines       13870    13870           
=======================================
  Hits         7870     7870           
  Misses       5336     5336           
  Partials      664      664

@CecileRobertMichon
Copy link
Contributor

The commit message needs to be changed to use the "fix:" semantics (squash commit will use the first PR commit, not the title)

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending passing VHD build (I believe the pipeline is broken atm)

@CecileRobertMichon
Copy link
Contributor

fixed the pipeline and queued a new build

@CecileRobertMichon
Copy link
Contributor

VHD build is failing with 2019-02-26T01:22:49.3024544Z �[0;32m azure-arm: /home/packer/provision_installs.sh: line 9: CONTAINERD_VERSION: unbound variable�[0m

Looks like a regression from #516 @jackfrancis FYI

Let's not merge this until it's fixed

/hold

@jackfrancis
Copy link
Member

Good catch @CecileRobertMichon, I think this is the fix: #583

@jackfrancis
Copy link
Member

FYI rebased/force-pushed this on top of VHD CI-fixing commit in master.

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Feb 26, 2019
@jackfrancis jackfrancis merged commit ffa6556 into Azure:master Feb 26, 2019
@acs-bot
Copy link

acs-bot commented Feb 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awesomenix, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants