-
Notifications
You must be signed in to change notification settings - Fork 519
fix: Explicitly use overlay2 storage driver while creation of vhd, by defa… #574
Conversation
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 56.74% 56.74%
=======================================
Files 91 91
Lines 13870 13870
=======================================
Hits 7870 7870
Misses 5336 5336
Partials 664 664 |
The commit message needs to be changed to use the "fix:" semantics (squash commit will use the first PR commit, not the title) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending passing VHD build (I believe the pipeline is broken atm)
fixed the pipeline and queued a new build |
VHD build is failing with Looks like a regression from #516 @jackfrancis FYI Let's not merge this until it's fixed /hold |
Good catch @CecileRobertMichon, I think this is the fix: #583 |
… default docker uses aufs
FYI rebased/force-pushed this on top of VHD CI-fixing commit in master. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awesomenix, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… default docker uses aufs (Azure#574)
…ult docker uses aufs
Reason for Change:
By default docker uses aufs storage driver, hence while creation of vhd, the container images are always downloaded to wrong partition /var/lib/docker/aufs while we start docker with overlay2 storage driver after creation of vm. Configure docker engine to use overlay2 after installation during vhd creation.
Issue Fixed:
Requirements:
Notes: