Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: wait longer when incrementing error count waiting for pod Ready #560

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

We implement the following algorithm when assessing for pod readiness in our E2E tests:

  • wait for n Ready reponses
  • keep track of non-Ready responses as f
  • if/when f reaches a count that equals the desired n count before we have tracked the desired Ready responses, return a failure response, as we interpret that to mean that the pod may be thrashing between Ready and non-Ready

(The above algorithm is only implemented if n is greater than 1. If n is 1 then we simply wait for a single Ready response in a given timeout interval.)

In order to eliminate false positive signals due to "normal" operational pod reconciliation, we should wait longer if we get a non-Ready signal, and allow the k8s control plane more time to reconcile the pod into a consistent Ready state.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #560 into master will decrease coverage by 1.94%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage    56.7%   54.75%   -1.95%     
==========================================
  Files          91       97       +6     
  Lines       13859    14708     +849     
==========================================
+ Hits         7859     8054     +195     
- Misses       5334     5980     +646     
- Partials      666      674       +8

@mboersma
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Feb 22, 2019
@jackfrancis jackfrancis merged commit c5e7716 into Azure:master Feb 22, 2019
@acs-bot
Copy link

acs-bot commented Feb 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis deleted the e2e-retry-if-waiting-for-pod branch February 22, 2019 17:43
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants