This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: wait longer between kubectl top nodes retries #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
======================================
Coverage 54.6% 54.6%
======================================
Files 97 97
Lines 14649 14649
======================================
Hits 7999 7999
Misses 5975 5975
Partials 675 675 |
sylr
pushed a commit
to sylr/aks-engine
that referenced
this pull request
Feb 28, 2019
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Intermittent
kubectl top nodesfailure test signal due to possibly transient metrics-server issues. Adding more retry time here to be more tolerant to Azure.This PR will wait 10 minutes (1 retry per minute) to get a successful
kubectl top nodesresult.Issue Fixed:
Fixes #533
Requirements:
Notes: