Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: updated acs to aks #524

Merged
merged 2 commits into from
Feb 15, 2019
Merged

fix: updated acs to aks #524

merged 2 commits into from
Feb 15, 2019

Conversation

marlonsingleton
Copy link
Contributor

Reason for Change:
Issue #475 as ACS is being deprecated

Issue Fixed:
Removed ACS, added AKS to documentation. Except for line 209, which is still hyperlinked to ACS documentation yet to be marked as deprecated

Requirements:

Notes:

updated apiversion, changed references to acs to aks except line 209
reverted apiVersion back to "2018-06-01" as courtesy. However "2018-10-01" is current.
@welcome
Copy link

welcome bot commented Feb 15, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/S label Feb 15, 2019
@jackfrancis
Copy link
Member

Thanks @marlonsingleton!

/lgtm

@acs-bot acs-bot added the lgtm label Feb 15, 2019
@jackfrancis jackfrancis merged commit 78d8ff0 into Azure:master Feb 15, 2019
@welcome
Copy link

welcome bot commented Feb 15, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@acs-bot
Copy link

acs-bot commented Feb 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, marlonsingleton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sylr pushed a commit to sylr/aks-engine that referenced this pull request Feb 28, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants