-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
FYI the generated files break the linting unfortunately :
|
Thanks @serbrech ! I've provided my comment |
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
=======================================
Coverage 54.35% 54.35%
=======================================
Files 96 96
Lines 14552 14552
=======================================
Hits 7910 7910
Misses 5969 5969
Partials 673 673 |
Does |
I believe it should not a problem. Kubernetes and Prometheus open source projects follow the pattern of license header first and then the Package doc. Their godocs seem to populate as expected. |
This looks like my local problem somehow. (The doc comment rendering doesn't get updated for me even when I make local modifications.) @serbrech showed me his renders correctly and I think @tariq1890's guidance is correct. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, serbrech, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* adding godoc package commnets * add i18n package level doc * reorder Copyright and Pakage doc comment for every packages
* adding godoc package commnets * add i18n package level doc * reorder Copyright and Pakage doc comment for every packages
Reason for Change:
Add missing godoc comments on packages where missing
Issue Fixed:
fix #29