Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: adding godoc package comments #502

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

serbrech
Copy link
Member

Reason for Change:

Add missing godoc comments on packages where missing

Issue Fixed:

fix #29

@acs-bot acs-bot added the size/S label Feb 13, 2019
@serbrech
Copy link
Member Author

FYI the generated files break the linting unfortunately :

golint $(go list ./... | grep -v /vendor/) | grep comment
/go/src/github.com/Azure/aks-engine/pkg/engine/templates_generated.go:1:1: package comment should be of the form "Package engine ..."
/go/src/github.com/Azure/aks-engine/pkg/i18n/translations_generated.go:1:1: package comment should be of the form "Package i18n ..."

@tariq1890
Copy link
Contributor

Thanks @serbrech ! I've provided my comment

@acs-bot acs-bot added size/M and removed size/S labels Feb 13, 2019
@tariq1890
Copy link
Contributor

/lgtm

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #502 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #502   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files          96       96           
  Lines       14552    14552           
=======================================
  Hits         7910     7910           
  Misses       5969     5969           
  Partials      673      673

@mboersma
Copy link
Member

Does godoc pick up all these comments? I remember in 4324 I had to make the // Package comment on the first line to satisfy both godoc and our license checking script...

@tariq1890
Copy link
Contributor

tariq1890 commented Feb 13, 2019

I believe it should not a problem. Kubernetes and Prometheus open source projects follow the pattern of license header first and then the Package doc. Their godocs seem to populate as expected.

@mboersma
Copy link
Member

mboersma commented Feb 13, 2019

I ran godoc -http=:6060 on this branch and I don't see package comments for some of those where we've put the copyright header first. cmd for example:
screen shot 2019-02-13 at 2 32 42 pm

@mboersma
Copy link
Member

This looks like my local problem somehow. (The doc comment rendering doesn't get updated for me even when I make local modifications.) @serbrech showed me his renders correctly and I think @tariq1890's guidance is correct.

@mboersma
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, serbrech, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890 tariq1890 merged commit 9f2b5b8 into Azure:master Feb 14, 2019
sylr pushed a commit to sylr/aks-engine that referenced this pull request Feb 28, 2019
* adding godoc package commnets

* add i18n package level doc

* reorder Copyright and Pakage doc comment for every packages
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
* adding godoc package commnets

* add i18n package level doc

* reorder Copyright and Pakage doc comment for every packages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing Go package comments
4 participants