fix: remove repair-malformed-updates deprecated flag

[ritazh]

Reason for Change:

Remove repair-malformed-updates deprecated flag

Issue Fixed:

Fixes #490

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

[tariq1890]

I understand that this is removed for k8s 1.14. Does the removal of this have consequences for other k8s clusters?

[codecov]

Codecov Report

Merging #492 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   54.35%   54.36%   +<.01%     
==========================================
  Files          96       96              
  Lines       14552    14555       +3     
==========================================
+ Hits         7910     7913       +3     
  Misses       5969     5969              
  Partials      673      673

[PatrickLang]

cc @adelina-t this could be breaking Windows test passes too

[feiskyer]

lgtm

[feiskyer]

Thanks for the fix.

[jackfrancis]

s/removed/deprecated

[jackfrancis]

@ritazh Add this test to defaults-apiserver_test.go, it should pass in your PR:

func TestAPIServerConfigRepairMalformedUpdates(t *testing.T) {
	// Test default
	cs := CreateMockContainerService("testcluster", "1.13.0", 3, 2, false)
	cs.setAPIServerConfig()
	a := cs.Properties.OrchestratorProfile.KubernetesConfig.APIServerConfig
	if a["--repair-malformed-updates"] != "false" {
		t.Fatalf("got unexpected default value for '--repair-malformed-updates' API server config: %s",
			a["--repair-malformed-updates"])
	}

	// Validate that 1.14.0 doesn't include --repair-malformed-updates at all
	cs = CreateMockContainerService("testcluster", "1.14.0", 3, 2, false)
	cs.setAPIServerConfig()
	a = cs.Properties.OrchestratorProfile.KubernetesConfig.APIServerConfig
	if _, ok := a["--repair-malformed-updates"]; ok {
		t.Fatalf("got a value for the deprecated '--repair-malformed-updates' API server config: %s",
			a["--repair-malformed-updates"])
	}
}

[jackfrancis]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment