Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: do not create route table when using flannel #486

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

mkosieradzki
Copy link
Contributor

@mkosieradzki mkosieradzki commented Feb 12, 2019

Reason for Change:

Flannel uses VXLAN encapsulation... so using route table makes no sense...

Issue Fixed:

Requirements:

Notes:
Trivial and obvious low hanging fruit.

@welcome
Copy link

welcome bot commented Feb 12, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@mkosieradzki mkosieradzki changed the title Do not create route table when using flannel [fix] do not create route table when using flannel Feb 12, 2019
@mkosieradzki mkosieradzki changed the title [fix] do not create route table when using flannel fix: do not create route table when using flannel Feb 12, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #486 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files          97       97           
  Lines       14622    14622           
=======================================
  Hits         7978     7978           
  Misses       5971     5971           
  Partials      673      673

Flannel uses VXLAN encapsulation... so using route table makes no sense...
@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mkosieradzki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit e63578b into Azure:master Feb 16, 2019
sylr pushed a commit to sylr/aks-engine that referenced this pull request Feb 28, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants