Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Add agentpool resource(used for agentpool level operations) and UT #439

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

kkmsft
Copy link
Contributor

@kkmsft kkmsft commented Feb 5, 2019

Add agentpool resource(used for agentpool level operations) and UT

Reason for Change:

Agentpool resource definition is required for operating on agentpool as a resource. This is in preparation to the AKS multiagentpool work. There is no usage in aks-engine yet. AgentPoolProfile is used to represent the agentpool in a cluster. This is included in the AgentPoolResource as its properties field.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #439 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   53.38%   53.42%   +0.03%     
==========================================
  Files          95       95              
  Lines       14374    14385      +11     
==========================================
+ Hits         7674     7685      +11     
  Misses       6037     6037              
  Partials      663      663

Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, kkmsft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acs-bot acs-bot merged commit 53d5514 into Azure:master Feb 5, 2019
@kkmsft kkmsft deleted the agentpoolresource branch February 5, 2019 22:40
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants