Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: add commit message categories to PR template #421

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Feb 1, 2019

Reason for Change:

When opening a PR I like to have a visual of all the different commit types available, especially for the ones that aren't as obvious as "fix" and "feat". The list I added is a comment so it won't show in PR descriptions, just in the template when someone creates a PR.

Issue Fixed:

Requirements:

Notes:

@jackfrancis
Copy link
Member

/lgtm

Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890 tariq1890 merged commit 3137c3d into Azure:master Feb 1, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
@CecileRobertMichon CecileRobertMichon deleted the pr-template branch April 18, 2019 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants