feat: Support dynamic AzureEnvironmentSpecConfig #386

honcao · 2019-01-25T22:08:25Z

Reason for Change:

Feature Change for #278

Issue Fixed:

Fix #278

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

codecov · 2019-01-25T22:25:19Z

Codecov Report

Merging #386 into master will decrease coverage by 0.09%.
The diff coverage is 98.39%.

@@            Coverage Diff            @@
##           master     #386     +/-   ##
=========================================
- Coverage   53.42%   53.33%   -0.1%     
=========================================
  Files          95       98      +3     
  Lines       14361    16769   +2408     
=========================================
+ Hits         7673     8943   +1270     
- Misses       6025     7047   +1022     
- Partials      663      779    +116

honcao · 2019-01-25T23:35:35Z

/assign @jackfrancis

pkg/api/azenvtypes.go

…ironmentspec

honcao · 2019-01-28T19:45:04Z

@jackfrancis Thanks to review the code. I resolve the your comments and E2E test are passed now with the latest code.

pkg/api/defaults.go

…ironmentspec

pkg/api/azenvtypes.go

pkg/api/vlabs/const.go

pkg/api/vlabs/azenvtypes.go

jackfrancis · 2019-01-30T23:04:13Z

@honcao I understand why we need to define new types for these configurations in the vlabs type spec, as we're now going to be accepting them as configurable input. I don't understand why we need to copy over all the default values, however, as we can re-use the existing defaults flow that happens after the vlabs type has been converted to the superset api type, right?

Am I missing something?

honcao · 2019-01-30T23:17:11Z

@jackfrancis , you are correct, we do not need all the defaults in azenvtypes.go, only AzureStackCloudSpec is required. I will update the code.

pkg/api/defaults.go

pkg/api/azenvtypes.go

Co-Authored-By: honcao <honcao@microsoft.com>

…into environmentspec

pkg/api/defaults.go

honcao · 2019-02-06T22:36:58Z

@jackfrancis thanks.
Could we merge the PR as-is now? It will unblock me to send PR to support dynamic location.

And I will follow up with team to collect thoughts and refractor the code later?

pkg/api/defaults.go

pkg/helpers/helpers.go

pkg/api/defaults.go

pkg/helpers/helpers.go

pkg/engine/params_k8s.go

pkg/api/defaults.go

pkg/api/types.go

pkg/api/types_test.go

tariq1890

LGTM

mboersma · 2019-02-12T16:30:45Z

/lgtm

acs-bot · 2019-02-12T16:31:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honcao, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Support dynamic AzureEnvironmentSpecConfig * remove the DcosSpecConfig from surface area * use !="" to compare string for readability * remove unused default AzureEnvironmentSpecConfig in vlabs * Update pkg/api/azenvtypes.go for AzureStackCloudSpec comments Co-Authored-By: honcao <honcao@microsoft.com> * put default value of Azure Stack Environment Spec Config into default.go * add an wapper assging the dst string if the src string is not empty * assigning structs to variables for reuse * add new pubic function to support azurestack. * update comments for GetDefaultStringWithOverwrite * move set default custom cloud profile to seperate file

Support dynamic AzureEnvironmentSpecConfig

338efa7

acs-bot added the size/XXL label Jan 25, 2019

acs-bot assigned jackfrancis Jan 25, 2019

jackfrancis reviewed Jan 26, 2019

View reviewed changes

pkg/api/azenvtypes.go Outdated Show resolved Hide resolved

honcao added 2 commits January 25, 2019 16:54

remove the DcosSpecConfig from surface area

00a25b7

Merge branch 'master' of https://github.com/Azure/aks-engine into env…

1613a99

…ironmentspec

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

honcao added 2 commits January 30, 2019 14:22

use !="" to compare string for readability

ca6ed82

Merge branch 'master' of https://github.com/Azure/aks-engine into env…

37616e2

…ironmentspec

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/azenvtypes.go Show resolved Hide resolved

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/vlabs/const.go Outdated Show resolved Hide resolved

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/vlabs/const.go Outdated Show resolved Hide resolved

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/vlabs/azenvtypes.go Outdated Show resolved Hide resolved

jackfrancis reviewed Jan 30, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

remove unused default AzureEnvironmentSpecConfig in vlabs

6989169

tariq1890 reviewed Feb 1, 2019

View reviewed changes

pkg/api/azenvtypes.go Outdated Show resolved Hide resolved

tariq1890 and others added 3 commits February 1, 2019 11:55

Update pkg/api/azenvtypes.go for AzureStackCloudSpec comments

aacdbf5

Co-Authored-By: honcao <honcao@microsoft.com>

put default value of Azure Stack Environment Spec Config into default.go

d5f5990

Merge branch 'environmentspec' of https://github.com/honcao/aks-engine …

dd28160

…into environmentspec

jackfrancis reviewed Feb 4, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 7, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

add an wapper assging the dst string if the src string is not empty

23f23e5

tariq1890 reviewed Feb 8, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 8, 2019

View reviewed changes

pkg/helpers/helpers.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 8, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

assigning structs to variables for reuse

33ebed1

tariq1890 reviewed Feb 8, 2019

View reviewed changes

pkg/helpers/helpers.go Outdated Show resolved Hide resolved

honcao added 2 commits February 9, 2019 04:50

add new pubic function to support azurestack.

a1ddb73

update comments for GetDefaultStringWithOverwrite

f63541d

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/helpers/helpers.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/engine/params_k8s.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/api/defaults.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/api/types.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/api/types_test.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/api/types_test.go Outdated Show resolved Hide resolved

tariq1890 reviewed Feb 11, 2019

View reviewed changes

pkg/api/types_test.go Outdated Show resolved Hide resolved

move set default custom cloud profile to seperate file

afc1641

tariq1890 changed the title ~~feat:Support dynamic AzureEnvironmentSpecConfig~~ feat: Support dynamic AzureEnvironmentSpecConfig Feb 12, 2019

tariq1890 approved these changes Feb 12, 2019

View reviewed changes

acs-bot assigned mboersma Feb 12, 2019

acs-bot added the lgtm label Feb 12, 2019

mboersma added the approved label Feb 12, 2019

mboersma merged commit 7975ccb into Azure:master Feb 12, 2019

honcao deleted the environmentspec branch March 4, 2019 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support dynamic AzureEnvironmentSpecConfig #386

feat: Support dynamic AzureEnvironmentSpecConfig #386

honcao commented Jan 25, 2019

codecov bot commented Jan 25, 2019 •

edited

Loading

honcao commented Jan 25, 2019

honcao commented Jan 28, 2019

jackfrancis commented Jan 30, 2019

honcao commented Jan 30, 2019

honcao commented Feb 6, 2019

tariq1890 left a comment

mboersma commented Feb 12, 2019

acs-bot commented Feb 12, 2019

feat: Support dynamic AzureEnvironmentSpecConfig #386

feat: Support dynamic AzureEnvironmentSpecConfig #386

Conversation

honcao commented Jan 25, 2019

codecov bot commented Jan 25, 2019 • edited Loading

Codecov Report

honcao commented Jan 25, 2019

honcao commented Jan 28, 2019

jackfrancis commented Jan 30, 2019

honcao commented Jan 30, 2019

honcao commented Feb 6, 2019

tariq1890 left a comment

Choose a reason for hiding this comment

mboersma commented Feb 12, 2019

acs-bot commented Feb 12, 2019

codecov bot commented Jan 25, 2019 •

edited

Loading