This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: set heapster Deployment to EnsureExists to prevent heapster-nann… #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-induced pod thrashing
|
@sgoings FYI |
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
=======================================
Coverage 53.16% 53.16%
=======================================
Files 95 95
Lines 14244 14244
=======================================
Hits 7573 7573
Misses 6006 6006
Partials 665 665 |
|
lgtm |
mboersma
approved these changes
Jan 11, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
added a commit
that referenced
this pull request
Jan 11, 2019
#295) * fix: set heapster Deployment to EnsureExists to prevent heapster-nanny-induced pod thrashing * fix: actually change the Deployment spec
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Azure#295) * fix: set heapster Deployment to EnsureExists to prevent heapster-nanny-induced pod thrashing * fix: actually change the Deployment spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y-induced pod thrashing
Reason for Change:
aks-engine currently delivers a heapster implementation (for clusters < 1.13) that configures the
Deploymentaddon toReconcile, in order to enforce k8s runtime updates to configuration changes from heapster. In practice, folks are experiencing the theheapster-nannycontainer is inducing regular reconciliations (read: kill/recreate) of theheapsterpod.This sets the
DeploymenttoEnsureExistsinstead, which we expect to fix the above symptom; and will require manual reconciliation (read:kubectl delete pod <heapster pod id>) in order to apply changes to the addon spec.Issue Fixed:
Fixes #275
Requirements:
Notes: