This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: replace some leftover acsengine by aksengine #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacongobbler
approved these changes
Jan 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 53.16% 53.16%
=======================================
Files 95 95
Lines 14244 14244
=======================================
Hits 7573 7573
Misses 6006 6006
Partials 665 665 |
|
/lgtm |
tariq1890
approved these changes
Jan 10, 2019
|
/hold Let's get #253 merged first, as this one will probably be easier to resolve merge conflicts than that one |
CecileRobertMichon
force-pushed
the
fix-generator-src
branch
from
2014567 to
912416e
Compare
|
@bacongobbler I rebased can you please do a quick check to make sure I didn't unintentionally undo some of your doc changes? |
|
/hold cancel |
bacongobbler
approved these changes
Jan 11, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
pushed a commit
that referenced
this pull request
Jan 11, 2019
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fix some acs-engine references that were left in the code. Most are variables. One is the
generatorCodethat is used in theCreationSourcetag for VMs.Issue Fixed:
Requirements:
Notes: