Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: remove Kubernetes 1.6 heapster version from VHD script #233

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Jan 4, 2019

Reason for Change:

heapster:v1.3.0 was included in the VHD image, but it is only needed by Kubernetes 1.6 which is available for legacy ACS support.

Issue Fixed:

Requirements:

Notes:

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #233 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files          95       95           
  Lines       14240    14240           
=======================================
  Hits         7580     7580           
  Misses       5994     5994           
  Partials      666      666

@mboersma mboersma merged commit 0e7d400 into Azure:master Jan 4, 2019
@mboersma mboersma deleted the vhd-diet branch January 4, 2019 19:11
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants