-
Notifications
You must be signed in to change notification settings - Fork 519
Conversation
These scripts/Dockerfiles are either unused by CI or are not actively being maintained, so I assume these are safe to remove. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
0973499
to
855081a
Compare
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 53.23% 53.23%
=======================================
Files 95 95
Lines 14240 14240
=======================================
Hits 7580 7580
Misses 5994 5994
Partials 666 666 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks like cruft to me. I could never figure out where the Dockerfile might be used so left it alone out of caution, but now that we've switched over to aks-engine let's tidy up. We can always restore a file if needed.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bacongobbler, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do we want to add a follow up item to standardize upon a canonical docker image for aks-engine development/CI? |
Yeah that may be a nice-to-have. I'll file a ticket for that now |
@jackfrancis you mean other than deis/go-dev? I think we use that consistently now that this cruft is removed, but we could consider alternatives. |
@mboersma Not concretedly "instead of", as possibly "deis/go-dev" is the appropriate docker environment for aks-engine dev long-term. I think we just want to standardize that, with community input. |
This PR breaks the doc: https://github.com/Azure/aks-engine/blob/master/docs/tutorials/quickstart.md#docker-development-environment. Is it expected? |
These scripts/Dockerfiles are either unused by CI or are not actively being maintained, so I assume these are safe to remove. Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Reason for Change: These scripts/Dockerfiles are either unused by CI or are not actively being maintained, so I assume these are safe to remove.
I'm not totally sure about removing the root Dockerfile, but given that there are several outdated packages in there I assumed it was also stale. Please let me know if that is not and I'm happy to restore anything that is still in active use.
Requirements:
Notes: