Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: remove stale scripts #224

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

bacongobbler
Copy link
Contributor

Reason for Change: These scripts/Dockerfiles are either unused by CI or are not actively being maintained, so I assume these are safe to remove.

I'm not totally sure about removing the root Dockerfile, but given that there are several outdated packages in there I assumed it was also stale. Please let me know if that is not and I'm happy to restore anything that is still in active use.

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Jan 3, 2019
These scripts/Dockerfiles are either unused by CI or are not actively being maintained, so I assume these are safe to remove.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #224 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   53.23%   53.23%           
=======================================
  Files          95       95           
  Lines       14240    14240           
=======================================
  Hits         7580     7580           
  Misses       5994     5994           
  Partials      666      666

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks like cruft to me. I could never figure out where the Dockerfile might be used so left it alone out of caution, but now that we've switched over to aks-engine let's tidy up. We can always restore a file if needed.

@mboersma
Copy link
Member

mboersma commented Jan 4, 2019

/lgtm

@acs-bot
Copy link

acs-bot commented Jan 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bacongobbler, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member

Do we want to add a follow up item to standardize upon a canonical docker image for aks-engine development/CI?

@bacongobbler
Copy link
Contributor Author

Yeah that may be a nice-to-have. I'll file a ticket for that now

@mboersma
Copy link
Member

mboersma commented Jan 4, 2019

@jackfrancis you mean other than deis/go-dev? I think we use that consistently now that this cruft is removed, but we could consider alternatives.

@jackfrancis
Copy link
Member

@mboersma Not concretedly "instead of", as possibly "deis/go-dev" is the appropriate docker environment for aks-engine dev long-term. I think we just want to standardize that, with community input.

@bacongobbler bacongobbler merged commit f1c051e into Azure:master Jan 4, 2019
@bacongobbler bacongobbler deleted the remove-stale-scripts branch January 4, 2019 21:14
@bingosummer
Copy link
Member

juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
These scripts/Dockerfiles are either unused by CI or are not actively being maintained, so I assume these are safe to remove.

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants