Missing ValidatingWebhookConfiguration

[IvanJosipovic]

Hello,

I noticed that this operator does not deploy the ValidatingWebhookConfiguration which is part of the open-source nginx ingress. This webhook validates the Ingress objects for many conditions.

Is this by design?

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
  annotations:
    meta.helm.sh/release-name: ingress-nginx
    meta.helm.sh/release-namespace: ingress
  generation: 2
  labels:
    app.kubernetes.io/component: admission-webhook
    app.kubernetes.io/instance: ingress-nginx
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: ingress-nginx
    app.kubernetes.io/part-of: ingress-nginx
    app.kubernetes.io/version: 1.10.4
    helm.sh/chart: ingress-nginx-4.10.4
  name: ingress-nginx-admission
webhooks:
- admissionReviewVersions:
  - v1
  clientConfig:
    caBundle: >
      -----BEGIN CERTIFICATE-----
      ...
      -----END CERTIFICATE-----
    service:
      name: ingress-nginx-controller-admission
      namespace: ingress
      path: /networking/v1/ingresses
      port: 443
  failurePolicy: Fail
  matchPolicy: Equivalent
  name: validate.nginx.ingress.kubernetes.io
  namespaceSelector: {}
  objectSelector: {}
  rules:
  - apiGroups:
    - networking.k8s.io
    apiVersions:
    - v1
    operations:
    - CREATE
    - UPDATE
    resources:
    - ingresses
    scope: '*'
  sideEffects: None
  timeoutSeconds: 10

Without this webhook, we can commit invalid Ingress objects such as:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: one
  namespace: default
spec:
  rules:
  - host: testapp.test.loc
    http:
      paths:
      - backend:
          service:
            name: app
            port:
              number: 8080
        path: /
        pathType: ImplementationSpecific
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: two
  namespace: default
spec:
  rules:
  - host: testapp.test.loc
    http:
      paths:
      - backend:
          service:
            name: app
            port:
              number: 8080
        path: /
        pathType: ImplementationSpecific

With the webhook, we receive the following error:
Ingress/default/one dry-run failed (BadRequest): admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: host "testapp.test.loc" and path "/" is already defined in ingress default-radius-app1/ingress

[IvanJosipovic]

It was by design, #151, then I would consider this a bug.