Proposed ECMP Next Hop CLI Show Cmd Output Format #659

kktheballer · 2020-08-11T01:15:05Z

Adding CLI command formats for

show fgnhg hash-view
show fgnhg active-hops

anish-n · 2020-08-13T00:36:13Z

doc/ecmp/fine_grained_next_hop_hld.md

@@ -189,6 +189,29 @@ CLI commands:
 	show fg nhg active-hops <fg-nhg-group-name> (shows which set of next-hops are active) 
 ```

+### 2.3.1 CLI 'show fg nhg hash-view' Output Format


This supports a fg-nhg-group-name argument as listed in above section?

anish-n · 2020-08-13T00:41:56Z

doc/ecmp/fine_grained_next_hop_hld.md

+--------------  -----------------------------------------------------------------------------------------------------------------------
+200.200.200.1   ['88', '89', '102', '103', '100', '101', '99', '98', '91', '90', '93', '92', '95', '94', '97', '96']
+200.200.200.2   ['41', '20', '21', '22', '23', '15', '17', '16', '19', '18', '46', '44', '45', '42', '43', '40']
+200.200.200.3   ['64', '65', '66', '67', '68', '69', '77', '76', '75', '74', '73', '72', '71', '70', '78']


How about 88, 89, 102, 103 without the array like syntax and without single quotes?

anish-n · 2020-08-13T00:43:40Z

doc/ecmp/fine_grained_next_hop_hld.md

+Next-Hop-Key    Hash Bucket #
+--------------  -----------------------------------------------------------------------------------------------------------------------
+200.200.200.1   ['88', '89', '102', '103', '100', '101', '99', '98', '91', '90', '93', '92', '95', '94', '97', '96']
+200.200.200.2   ['41', '20', '21', '22', '23', '15', '17', '16', '19', '18', '46', '44', '45', '42', '43', '40']


A sorted set of integer values for 'Hash Bucket #' may be better

anish-n · 2020-08-13T00:48:13Z

doc/ecmp/fine_grained_next_hop_hld.md

@@ -189,6 +189,29 @@ CLI commands:
 	show fg nhg active-hops <fg-nhg-group-name> (shows which set of next-hops are active) 
 ```


Can we also add details about cli output for 'show fg nhg group'?

anish-n · 2020-10-08T22:07:01Z

doc/ecmp/fine_grained_next_hop_hld.md

+
+
+-----------------------------+--------------------+------------+
+| FG_NHG_PREFIX               | Active Next Hops   | Bank Ids   |


Recommend changing Bank Ids to Hash buckets and NIT: Active Next Hops to Next Hop

Ok will adjust both PRs accordingly

anish-n

Looks good

abdosi

LGTM

anish-n · 2020-12-21T21:25:28Z

doc/ecmp/fine_grained_next_hop_hld.md

- Test warm reboot to ensure there is no traffic disruption and ECMP groups are correctly applied post warm boot
+# SONiC Fine Grained ECMP 
+# High Level Design Document
+### Rev 1.2


Please can we update the rev number here to the latest 1.3.

anish-n · 2020-12-21T21:26:56Z

Why does it appear that the whole file was modified, hope we can correct that since it helps with maintaining version history.

1) show ecmp fg-nhg-active-hops <fg-nhg-group-name> 2) show ecmp fg-nhg-hash-view <fg-nhg-group-name> Also have added description about <fg-nhg-group-name> param

Merge conflict between Rev1.2 and Rev1.3 also resolved

anish-n · 2020-12-21T23:38:18Z

doc/ecmp/fine_grained_next_hop_hld.md

+### 2.3.1 CLI 'show fgnhg hash-view <fg-nhg-group-name>' Output Format
+```
+
+NOTE: <fg-nhg-group-name> is an optional parameter containing the user-defined alias of nhg ipv4 or nhg ipv6 


Suggest that we reword this to say NOTE: <fg-nhg-group-name> is an optional parameter containing the user-defined alias defined via FG_NHG entry

anish-n · 2020-12-21T23:40:52Z

doc/ecmp/fine_grained_next_hop_hld.md

 ```

-Show CLI commands of ```show fg nhg hash-view``` and ```show fg nhg active-hops``` are implemented as a view of the state db table described in section 2.2
+### 2.3.1 CLI 'show fgnhg hash-view <fg-nhg-group-name>' Output Format


This does not show up as expected when viewed as markdown in the reader, maybe a markdown syntax issue, can you please fix the same

Addressed and made some more changes within section description

Minor edit to section description as well

abdosi · 2021-01-20T02:49:42Z

please add details in description

anish-n reviewed Aug 13, 2020

View reviewed changes

kktheballer force-pushed the master branch from b8a87f0 to 99cc610 Compare August 18, 2020 01:40

kktheballer force-pushed the master branch from 99cc610 to d99bbe1 Compare September 8, 2020 17:30

anish-n reviewed Oct 8, 2020

View reviewed changes

kktheballer force-pushed the master branch from d99bbe1 to 34ab4b9 Compare October 13, 2020 00:53

kktheballer force-pushed the master branch from 34ab4b9 to 57a6e13 Compare October 21, 2020 22:31

anish-n approved these changes Oct 26, 2020

View reviewed changes

abdosi approved these changes Nov 17, 2020

View reviewed changes

anish-n reviewed Dec 21, 2020

View reviewed changes

kktheballer added 4 commits December 21, 2020 14:54

Proposed ECMP Next Hop CLI Show Cmd Output Format

a93dc72

Adding CLI output format for show-nhg-group

5c4151a

Restructured format for the following CLI commands:

9d6284d

1) show ecmp fg-nhg-active-hops <fg-nhg-group-name> 2) show ecmp fg-nhg-hash-view <fg-nhg-group-name> Also have added description about <fg-nhg-group-name> param

Modifying Command Syntax and Output Table Column Values

7f21fff

kktheballer force-pushed the master branch 2 times, most recently from 65d7028 to 56af004 Compare December 21, 2020 23:15

Minor updates to fgnhg CLI command output syntax

d331f5f

Merge conflict between Rev1.2 and Rev1.3 also resolved

kktheballer force-pushed the master branch from 56af004 to d331f5f Compare December 21, 2020 23:21

anish-n reviewed Dec 21, 2020

View reviewed changes

Minor revision to command param description

0e1821c

anish-n reviewed Dec 21, 2020

View reviewed changes

Minor title formatting to command format section

d8c3480

Minor edit to section description as well

kktheballer force-pushed the master branch from 68f0eb5 to d8c3480 Compare December 27, 2020 22:34

abdosi merged commit acf4741 into sonic-net:master Jan 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposed ECMP Next Hop CLI Show Cmd Output Format #659

Proposed ECMP Next Hop CLI Show Cmd Output Format #659

kktheballer commented Aug 11, 2020 •

edited

Loading

anish-n Aug 13, 2020

anish-n Aug 13, 2020

anish-n Aug 13, 2020

anish-n Aug 13, 2020

anish-n Oct 8, 2020

kktheballer Oct 8, 2020

anish-n left a comment

abdosi left a comment

anish-n Dec 21, 2020

anish-n commented Dec 21, 2020

anish-n Dec 21, 2020

anish-n Dec 21, 2020

kktheballer Dec 28, 2020

abdosi commented Jan 20, 2021

		@@ -189,6 +189,29 @@ CLI commands:
		show fg nhg active-hops <fg-nhg-group-name> (shows which set of next-hops are active)
		```



		+-----------------------------+--------------------+------------+
		\| FG_NHG_PREFIX \| Active Next Hops \| Bank Ids \|

Proposed ECMP Next Hop CLI Show Cmd Output Format #659

Proposed ECMP Next Hop CLI Show Cmd Output Format #659

Conversation

kktheballer commented Aug 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anish-n left a comment

Choose a reason for hiding this comment

abdosi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anish-n commented Dec 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abdosi commented Jan 20, 2021

kktheballer commented Aug 11, 2020 •

edited

Loading