diff --git a/pyrit/common/net_utility.py b/pyrit/common/net_utility.py index 1e2df8f46..97c23373b 100644 --- a/pyrit/common/net_utility.py +++ b/pyrit/common/net_utility.py @@ -22,13 +22,13 @@ def make_request_and_raise_if_error( method: str, request_body: dict[str, str] = None, headers: dict[str, str] = None, - use_proxy: bool = True, + debug: bool = False, ) -> httpx.Response: """Make a request and raise an exception if it fails.""" headers = headers or {} request_body = request_body or {} - with get_httpx_client(debug=use_proxy) as client: + with get_httpx_client(debug=debug) as client: if request_body: headers["Content-Type"] = "application/json" response = client.request(method=method, url=endpoint_uri, json=request_body, headers=headers) diff --git a/tests/test_common_net_utility.py b/tests/test_common_net_utility.py index cd2ac09cb..97d719b83 100644 --- a/tests/test_common_net_utility.py +++ b/tests/test_common_net_utility.py @@ -1,6 +1,8 @@ import pytest import httpx import respx + +from unittest.mock import patch, MagicMock from tenacity import RetryError from pyrit.common.net_utility import get_httpx_client, make_request_and_raise_if_error @@ -61,3 +63,13 @@ def response_callback(request): make_request_and_raise_if_error(endpoint_uri=url, method=method) assert call_count == 2, "The request should have been retried exactly once." assert mock_route.called + + +def test_debug_is_false_by_default(): + with patch("pyrit.common.net_utility.get_httpx_client") as mock_get_httpx_client: + mock_client_instance = MagicMock() + mock_get_httpx_client.return_value = mock_client_instance + + make_request_and_raise_if_error(endpoint_uri="http://example.com", method="GET") + + mock_get_httpx_client.assert_called_with(debug=False)