-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure App Configuration Push Task@6: Prefix not appended to Key value #810
Comments
Hello @j-noel-b , to make sure I understand, with the Azure App Configuration Push@6, you are unable to add the prefix ".appconfig.featureflag/someprefix" when pushing feature flags ? |
Sorry @MaryanneNjeri - the copy-paste from v3 got away from me in writing this ticket. I sincerely apologize for the confusion in the description. Here is our feature json:
here is our v6 task:
And here are the keys I am seeing in our feature manager:
Whereas I would expect to see:
Ultimately, we would like a colon in our prefix value such as |
@j-noel-b I see, seems there was a regression from version 5 of not appending prefixes for feature flags. We can explore the possibility of reintroducing the appending prefixes for feature flags. |
@MaryanneNjeri - thank you so much for the confirmation - much appreciated. |
Can i ask im having a nightmare of a time deploying the configuration file to the app config do you have an example of what your file that worked prior to this change looked like. You have no idea how much of a saviour you would be if you could. or if anyone else can as nothing ive attempted in the past five days seems to work.... |
@CMarshall92Shawbrook dependent on the content profile you are using Example configuration file
For appconfig/kvset Please see the example here |
So I tried the appconfig/kvset example and it worked but went into the configuration explorer and nothing appeared under the feature manager any ideas why this is the case?
|
@CMarshall92Shawbrook seems you are trying to import feature flags, with the
In your configuration explorer under Manage view > Settings ensure the option to "Include feature flags in the configuration explorer" is enabled Please let me know if this helps |
Can confirm that worked apologies for derailing this issue just thought it may have been related hopefully this will help out people in the future anyways. Is this 'Include feature flags in configuration explorer' mentioned in the docs if not might be worth adding as im sure i never once came across that |
Yes it is mentioned in the docs, Access feature flags |
Hello @j-noel-b the fix to address the regression where feature flags are not appended can be found in version 6.4.0 of the Azure App Configuration Push Task. Please let me know if this helps. |
With version 6 of the AzureAppConfigurationPush task, we no longer see the supplied prefix values being appended to the keys in our configuration. Version 3 works without issue in that our prefixes appear on the keys. We do see the ".appconfig.featureflag" appear on both versions but I am unsure if that is due to us providing that value in the prefix or if azure is managing that regardless. I have not tested versions between. Our prefix value does have a colon : in it, if that matters.
Our working version 3 code:
Our version 6 code:
Our team requires the use of the prefix, so we will stay with version 3 for the immediate time being, but we would appreciate any insight that can be provided.
The text was updated successfully, but these errors were encountered: