Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please change the namespace of the Configuration extensions methods #140

Closed
shibayan opened this issue Sep 16, 2019 · 6 comments
Closed
Assignees
Labels
.NET Config Provider Issues related to the AppConfig .NET Core configuration provider.

Comments

@shibayan
Copy link

As a convention of .NET Core / ASP.NET Core, the extension method namespace is generalized.

Azure App Configuration (2.0.0-preview-009470001-1371)

image

Example: Key Vault

image

I'd like you to change the namespace to match other Configuration libraries.

@jimmyca15
Copy link
Member

This is a breaking change. We can still take it at this point but we will need to weigh out the pros and cons on this.

@shibayan shibayan changed the title Please change the namespace of the Configuration library Please change the namespace of the Configuration extensions methods Sep 17, 2019
@zhenlan zhenlan added the .NET Config Provider Issues related to the AppConfig .NET Core configuration provider. label Sep 20, 2019
@abhilasharora abhilasharora self-assigned this Sep 20, 2019
@abhilasharora
Copy link
Contributor

@shibayan Thanks for the feedback. Since this is a breaking change, it might take a while, but we will include it in our next major release for the configuration provider.

@shibayan
Copy link
Author

@abhilasharora I think that Breaking change is allowed while previewing. You actually have deleted the Watch / WatchAndReloadAll method.

It was quite a breaking change for me

@jimmyca15
Copy link
Member

@shibayan I believe we moved from 1.x.x to 2.x.x with that change though? We certainly can make the change when we go to 3.x.x

@shibayan
Copy link
Author

@jimmyca15 Umm. In general, don't change the major version in preview. It is strange that the SDK version is v2.x.x or v3.x.x in the first release of the service 😕

I think it is important for usability to follow general rules.

@abhilasharora
Copy link
Contributor

@shibayan We just released version 2.1.0-preview of the packages with the namespace change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Config Provider Issues related to the AppConfig .NET Core configuration provider.
Projects
None yet
Development

No branches or pull requests

4 participants