Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default max retries for key vault requests #589

Closed
amerjusupovic opened this issue Aug 20, 2024 · 0 comments · Fixed by #592
Closed

Increase default max retries for key vault requests #589

amerjusupovic opened this issue Aug 20, 2024 · 0 comments · Fixed by #592
Assignees

Comments

@amerjusupovic
Copy link
Member

Currently, the default minimum refresh interval for configuration settings is 30 seconds. We've seen that some customers who use Key Vault secrets and have a shorter refresh interval may run into issues where Key Vault responds various errors, like with a 429 status code, when refreshing the secret. Because refreshing without the updated secret could have unexpected consequences, we can instead set the default maximum retries for the Key Vault client to the maximum value. This ensures that the provider will not skip loading a secret if Key Vault is still able to retry the request but will still handle any exceptions thrown by Key Vault the same as it does now.

@amerjusupovic amerjusupovic changed the title Increase default max retries for key vault calls Increase default max retries for key vault requests Aug 20, 2024
@amerjusupovic amerjusupovic linked a pull request Sep 4, 2024 that will close this issue
@amerjusupovic amerjusupovic self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant