Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseAzureAppConfiguration should be put in Microsoft.Azure.Functions.Worker namespace #299

Closed
zhenlan opened this issue Dec 16, 2021 · 5 comments · Fixed by #303
Closed
Assignees
Milestone

Comments

@zhenlan
Copy link
Contributor

zhenlan commented Dec 16, 2021

The UseAzureAppConfiguration extension method should be put in the same namespace as IFunctionsWorkerApplicationBuilder so users don't have to add the additional namespace Microsoft.Azure.AppConfiguration.Functions.Worker to their code.

@zhenlan
Copy link
Contributor Author

zhenlan commented Feb 3, 2022

Looks like we should have put it under Microsoft.Extensions.Hosting like other extension methods

https://docs.microsoft.com/en-us/dotnet/api/microsoft.extensions.hosting.middlewareworkerapplicationbuilderextensions.usedefaultworkermiddleware

@zhenlan zhenlan reopened this Feb 3, 2022
@avanigupta
Copy link
Member

Yes, totally missed that! However, changing the namespace will be a breaking change. Since we have already released 5.0.0 version today, this would need to be fixed in 6.0.0 release.

@zhenlan
Copy link
Contributor Author

zhenlan commented Feb 3, 2022

Sorry, it was an oversight on my part.

The Microsoft.Extensions.Hosting namespace should be present in users' projects already, so nothing will really be breaking. I am wondering if we can roll a 5.0.1 just for this package quickly.

@avanigupta
Copy link
Member

We can do a quick 5.0.1 release just for this package, and we can even deprecate 5.0.0 if needed.

@zhenlan
Copy link
Contributor Author

zhenlan commented Feb 3, 2022

Good idea. We can unlist 5.0.0 from nuget.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants