Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update middleware to throw when no refresher instance is found #166

Closed
abhilasharora opened this issue Jun 4, 2020 · 1 comment
Closed

Update middleware to throw when no refresher instance is found #166

abhilasharora opened this issue Jun 4, 2020 · 1 comment
Assignees
@abhilasharora
Labels
breaking change bug Something isn't working
Milestone
v4.0.0-preview

Comments

@abhilasharora
Copy link
Contributor

When no instance of IConfigurationRefresher could be retrieved from the IConfiguration instance received from the dependency injection container, the middleware should throw. This will help avoid silent failures in case there is an issue setting up App Configuration.
@abhilasharora abhilasharora self-assigned this Jun 4, 2020
@zhenlan zhenlan added breaking change bug Something isn't working labels Jun 5, 2020
@zhenlan zhenlan mentioned this issue Jun 5, 2020
Closed
@zhenlan zhenlan added this to the v4.0.0-Preview1 milestone Jul 20, 2020
@abhilasharora
Copy link
Contributor Author

These changes are now available in version 4.0.0-preview of the package.

@zhenlan zhenlan mentioned this issue Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhilasharora abhilasharora

Labels
breaking change bug Something isn't working
Projects
None yet
Milestone
v4.0.0-preview
Development

No branches or pull requests
2 participants
@zhenlan @abhilasharora