From ccd93a93d12f7a45b206a53fbb9b70395dd1d969 Mon Sep 17 00:00:00 2001 From: Zach Trocinski Date: Wed, 10 Apr 2024 02:57:35 -0500 Subject: [PATCH 1/2] Fix version references for known issue #1 --- docs/wiki/KnownIssues.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/wiki/KnownIssues.md b/docs/wiki/KnownIssues.md index 48d76c045..c3f9a6379 100644 --- a/docs/wiki/KnownIssues.md +++ b/docs/wiki/KnownIssues.md @@ -13,14 +13,15 @@ This page lists the known issues and limitations currently present in ALZ-Bicep. ```yaml - task: AzurePowerShell@5 - displayName: "Logging and Sentinel Deployment" + displayName: "Logging and Sentinel Resource Group Deployment" inputs: azureSubscription: ${{ variables.SERVICE_CONNECTION_NAME }} - azurePowerShellVersion: "11.3.0" + azurePowerShellVersion: OtherVersion + preferredAzurePowerShellVersion: 11.5.0 pwsh: true ScriptType: "InlineScript" Inline: | - .\pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1 + .\pipeline-scripts\Deploy-ALZLoggingAndSentinelResourceGroup.ps1 ``` GitHub Actions Workaround: @@ -31,7 +32,7 @@ This page lists the known issues and limitations currently present in ALZ-Bicep. with: inlineScript: | .\pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1 - azPSVersion: "11.3.0" + azPSVersion: "11.5.0" ``` - **Status:** As our team doesn't directly own the impacted module or have control over the agents/runners, we aim to enhance flexibility to assist with such issues in the future. To achieve this, we plan to introduce a variable in the .env file, enabling version control without the need for individual additions. From ce5486c152b2fb0a3e67f9346bd3e7c617febdc2 Mon Sep 17 00:00:00 2001 From: Zach Trocinski Date: Wed, 10 Apr 2024 03:00:55 -0500 Subject: [PATCH 2/2] Update to match modules for known issue 1 --- docs/wiki/KnownIssues.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/wiki/KnownIssues.md b/docs/wiki/KnownIssues.md index c3f9a6379..ee7769a42 100644 --- a/docs/wiki/KnownIssues.md +++ b/docs/wiki/KnownIssues.md @@ -27,11 +27,11 @@ This page lists the known issues and limitations currently present in ALZ-Bicep. GitHub Actions Workaround: ```yaml - - name: "Logging and Sentinel Deployment" + - name: "Logging and Sentinel Resource Group Deployment" uses: azure/powershell@v1 with: inlineScript: | - .\pipeline-scripts\Deploy-ALZLoggingAndSentinel.ps1 + .\pipeline-scripts\Deploy-ALZLoggingAndSentinelResourceGroup.ps1 azPSVersion: "11.5.0" ```