🪲 Bug Report - Hardcoded dependency on Corp and Online in Policy Assignment and Diagnostics bicep

[bram-boer]

Describe the bug

The Policy Assignment module and the Diagnostics module has hardcoded paths to the -corp and -online mg groups. even though you can select not to use them.
This fails the diag deployment in yml-1 and the policy assignment in yaml-2. deployment errors then are about invalidtokens which is very undesired and unclear.

To Reproduce

Steps to reproduce the behaviour:

1. deploy ALZ without -corp / -online management groups
2. deploy diagnostics on mg group -- error 1
3. deploy policy assignments on mg group -- error 2

Expected behaviour

We expected to have no error, and a deployment on Landingzones when no child MG's were there as we set the child groups to false in regards to the diagnostics.
We also expected the Corp Assigned policies to be set to the available managmenet group (Landing Zones) as this deployment has no online/corp differentiation.

Screenshots 📷

If applicable, add screenshots to help explain your problem. Please feel free to blur/cover any sensitive information.

Correlation ID

Diagnostics:
failed dpeloyment: 79a534d1-336e-4846-9003-a35cba4160fb
working deployment: 806dfe02-2d5f-48c8-b84a-713fb7a0e074

Additional context

In case of any additional information needed, please reachout over teams within MSFT

[jtracey93]

Hey @bram-boer,

Did you use the accelerator?

Can you confirm the following for the points you rasied:

1. Did you set the parameter parLandingZoneMgAlzDefaultsEnable to false in mgDiagSettingsAll.parameters.all.json?
2. We need to add a fix for landing zones like we did in Add parPlatformMgAlzDefaultsEnable parameter to policy assignment #551, ill start on this

Thanks

[bram-boer]

HI @jtracey93

Yes we used the accelerator to do this.

1. the parameter was indeed set to false.
2. this looks like a very good one indeed :)

thanks

[jtracey93]

#559 now merged