Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DaemonSet/microsoft-defender-collector-ds doesn't have priority class (not ensured for scheduling, potential security issue) #4798

Open
mblaschke-daimlertruck opened this issue Feb 14, 2025 · 1 comment
Labels
bug Needs Attention 👋 Issues needs attention/assignee/owner

Comments

@mblaschke-daimlertruck
Copy link

mblaschke-daimlertruck commented Feb 14, 2025

Describe the bug
The DaemonSet/microsoft-defender-collector-ds doesn't have any priority class and so is not enforced on the nodes. If nodes are full the defender Pod will not be scheduled.

How can the defender be a GA ready service when it's missing the priority class system-node-critical? An attacker could try to evict the defender Pod to avoid detection.

result of the missing Pod:

Events:
  Type     Reason            Age                    From               Message
  ----     ------            ----                   ----               -------
  Warning  FailedScheduling  15m (x178 over 6h25m)  default-scheduler  0/23 nodes are available: 1 Insufficient cpu. preemption: 0/23 nodes are available: 1 No
preemption victims found for incoming pod, 22 Preemption is not helpful for scheduling.

This is a possible security issue if workloads can prevent the defender from being scheduled on nodes.

To Reproduce
Steps to reproduce the behavior:

  1. use all the reserved resources of a node before DaemonSet/microsoft-defender-collector-ds can scheduled pods
  2. DaemonSet/microsoft-defender-collector-ds pod is missing on that node

Expected behavior
Follow the Kubernetes guidelines for best practises for important node services and add priorityClass system-node-critical to the Pods. Make sure the Pods are always scheduled.

Environment (please complete the following information):

  • AKS v1.30.7
@mblaschke-daimlertruck mblaschke-daimlertruck changed the title [BUG] DaemonSet/microsoft-defender-collector-ds doesn't have priority class (not ensured for scheduling) [BUG] DaemonSet/microsoft-defender-collector-ds doesn't have priority class (not ensured for scheduling, potential security issue) Feb 14, 2025
Copy link
Contributor

Action required from @aritraghosh, @julia-yin, @AllenWen-at-Azure

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs Attention 👋 Issues needs attention/assignee/owner label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs Attention 👋 Issues needs attention/assignee/owner
Projects
None yet
Development

No branches or pull requests

1 participant