Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't app-silo outgoing viewing keys anymore #9162

Open
Tracked by #8953
nventuro opened this issue Oct 10, 2024 · 3 comments
Open
Tracked by #8953

Don't app-silo outgoing viewing keys anymore #9162

nventuro opened this issue Oct 10, 2024 · 3 comments
Labels
C-aztec.nr Component: Aztec smart contract framework team-fairies Nico's team

Comments

@nventuro
Copy link
Contributor

nventuro commented Oct 10, 2024

Check with @benesjan whether this can be actually done.

@nventuro nventuro changed the title Don't app-silo viewing keys anymore (neither incoming nor outgoing) Don't app-silo outgoing viewing keys anymore Oct 10, 2024
@nventuro nventuro added C-aztec.nr Component: Aztec smart contract framework C-noir Component: Noir/Nargo team-fairies Nico's team and removed C-noir Component: Noir/Nargo labels Oct 10, 2024
@benesjan
Copy link
Contributor

It is still done. In all the constrained callsites we get the ovsk_app via this function on private context. Unconstrained callsites use this getter.

@nventuro
Copy link
Contributor Author

I think my comment was referencing the fact that someone (@sklppy88?) mentioned they thought you had found an issue with the removal of this siloing, and that you had said we could not get rid of it.

@sklppy88
Copy link
Contributor

sklppy88 commented Oct 16, 2024

I think we should talk more about this yes, I don't fully remember what was said but I do remember there was discussions on this and a difference between removing the app-siloing of the ivsk and ovsk. I think that before the ivsk_app was non-hardened, whereas the ovsk-app currently is hardened, maybe it had something to do with that ? I'll try to remember more what exactly it had to deal with.

@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-aztec.nr Component: Aztec smart contract framework team-fairies Nico's team
Projects
Status: Todo
Development

No branches or pull requests

3 participants