Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: signing messages with AccountWallet (from aztec.js) #11889

Open
FilipHarald opened this issue Feb 10, 2025 · 2 comments
Open

feat: signing messages with AccountWallet (from aztec.js) #11889

FilipHarald opened this issue Feb 10, 2025 · 2 comments
Labels
from-community This originated from the community :) team-fairies Nico's team

Comments

@FilipHarald
Copy link
Contributor

Perhaps this is a bit out of scope. But I'm trying to build a feature where the deployer of a contract can upload meta-data to the deployment to aztecscan.xyz . To streamline this for the deployers I was thinking that they could use the wallet-class that's provided from aztec.js. Here is the pseudo-code:

      const account = await getSchnorrAccount(...);
      const wallet = account.getWallet();

      await EasyPrivateVotingContract.deploy(wallet, votingAdmin).send();
      const metadataPayload = { deployersNote: "I did this", deployersGithub: "[url]" };
      const signedMsg = wallet.sign(JSON.stringify(metadataPayload));
      // send the signedMsg and metadataPayload to API for verification
@sklppy88 sklppy88 added the team-fairies Nico's team label Feb 10, 2025
@iAmMichaelConnor iAmMichaelConnor added the from-community This originated from the community :) label Feb 10, 2025
@wei3erHase
Copy link

wouldn't this break the fungibility between "Token contract deployed by Alice" and "Token contract deployed by Bob"? is this feature instance related, or contract class related?

for reference, in Etherscan, the 1st person to "create a contract class" does have the power to add the comments they like in the bytecode, since every subsequent contract deployed with the same bytecode will inherit the comments as well (and perhaps banners)

this isn't enforced by the "deployer" but on a "first come first serve" manner

@FilipHarald
Copy link
Contributor Author

@wei3erHase I was thinking that you should be able to add meta-data to both an instance and a contract class.

With comments in the bytecode, you mean the source code? Currently we only have functionality for uploading the artifact, not the source code. But you have a point. This could be one approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from-community This originated from the community :) team-fairies Nico's team
Projects
None yet
Development

No branches or pull requests

4 participants