Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase contains references to old avisynth.org #319

Open
Enyium opened this issue Jan 26, 2023 · 6 comments
Open

Codebase contains references to old avisynth.org #319

Enyium opened this issue Jan 26, 2023 · 6 comments

Comments

@Enyium
Copy link

Enyium commented Jan 26, 2023

When you search the codebase, there are many references to the old http://www.avisynth.org/ website, including in avisynth.h, on which many links give you 404 errors and that still refers you to a legacy Sourceforge repository.

The links should probably be changed to point to http://avisynth.nl/. E.g., http://www.avisynth.org/mediawiki/AviSynth_FAQ becomes http://avisynth.nl/index.php/AviSynth_FAQ.

@Reel-Deal
Copy link
Member

Reel-Deal commented Jan 26, 2023

Most of those instances come from the non-English documentation. I actually wanted to open up an issue to see what pinterf and and qyot27 think about deleting all of the foreign documentation, because all of it is far behind the English docs. The likelihood of someone that speaks a particular language updating the docs is slim to none. Plus, translation tools, while not perfect, have come a long way.

But back to the original topic. Slowly but surely I will go through all of the English documentation and replace old links with current ones.

Edit: I overlooked that all of the source code files have http://www.avisynth.org/ in the license. Maybe that should be updated to avisynth.nl. Wilbert used to own the avisynth.org domain so it used to redirect to avisynth.nl automatically. But that is no longer the case as Wilbert no longer owns avisynth.org: https://forum.doom9.org/showthread.php?p=1951636#post1951636

@pinterf
Copy link

pinterf commented Jan 26, 2023

Reel-Deal is right, translations are way behind the English version and will never be maintained.
Not only http://www.avisynth.org/ but most of the source code references Avisynth version 2.5.

@qyot27
Copy link
Member

qyot27 commented Jan 26, 2023

Indeed, I have thought about the case of just deleting the non-English docs, as even the idea of moving them to a second repo wouldn't accomplish all that much (it likely wouldn't be updated after being moved, so literally nothing changes - anyone wanting to have up-to-date docs for other languages would be vastly better served by working with the current RST/Sphinx docs anyway), and people could still grab the last version by thumbing back through the git history.

Source-code wise, yeah, avisynth.nl would be better in that regard. The version number references in the header, though, that's probably better left as-is unless we decide to do a full overhaul of all the code formatting and includes and what-all. It would make sense for AviSynth+-specific sources to be identified as such, rather than just copying the big header block from something as far back as 2.5 or even 1.0.

@Reel-Deal
Copy link
Member

Reel-Deal commented Jan 26, 2023

I'm in total favor of deleting the non-English docs. I have a PR ready to go :)

Moving them to a separate repo is also not a bad idea, at least for "archival" purposes.

I guess the same thing can be done with the FilterSDK folder which are not up-to-date. I believe the SDK sections in the rst docs have been updated.

@Enyium
Copy link
Author

Enyium commented Jan 26, 2023

I guess the same thing can be done with the FilterSDK folder which are not up-to-date. I believe the SDK sections in the rst docs have been updated.

https://avisynthplus.readthedocs.io/en/latest/avisynthdoc/FilterSDK/Cplusplus_api.html contains valuable documentation that I used during development. I also link to it in my doc comments a lot.

@Reel-Deal
Copy link
Member

Reel-Deal commented Jan 26, 2023

https://avisynthplus.readthedocs.io/en/latest/avisynthdoc/FilterSDK/Cplusplus_api.html contains valuable documentation that I used during development. I also link to it in my doc comments a lot.

That is contained in the rst docs: https://github.com/AviSynth/AviSynthPlus/tree/master/distrib/docs/english/source/avisynthdoc/FilterSDK - this will not be deleted. The online docs are automatically generated from here.

What I was referring to is this: https://github.com/AviSynth/AviSynthPlus/tree/master/distrib/FilterSDK - They are outdated html files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants