Obsolete CubicBezierEasing #13137
Merged
Obsolete CubicBezierEasing #13137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Oct 4, 2023
maxkatz6
added
backported-11.0.x
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
#Conflicts: # src/Avalonia.Base/Animation/Easings/CubicBezierEasing.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR "removes"
CubicBezierEasingby obsoleting it and deleting its implementation,CubicBezier.As noticed in #13043, this class can't be used publicly due to its constructor being internal, and is basically a duplicate of
SplineEasing+KeySpline.The class itself can't be removed as it would be a breaking change.
I've checked that the deleted
CubicBezierimplementation (from Chrome) andKeySpline(from WPF) return similar results. They start to differ slightly from the 4th decimal, which seems completely acceptable for an easing function. Plus,CubicBezieris roughly 50% slower thanKeySpline(.NET 7, x64, Release).