Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Upgrade to React 15.4.0 #9547

Merged
merged 4 commits into from
Nov 22, 2016
Merged

Framework: Upgrade to React 15.4.0 #9547

merged 4 commits into from
Nov 22, 2016

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Nov 21, 2016

Supersedes #9312

This pull request seeks to upgrade our React dependencies from 15.3.0 to 15.4.0 .

Changelogs:

Being a minor version bump, there aren't expected to be backwards-incompatible changes, though because we use internal undocumented libraries for our translate mixin, these were broken as part of the upgrade. Long-term we should seek to update all existing components to use the localize higher-order component, but in the meantime I've updated the existing references to their updated values, i.e.:

  • Before: require( 'react/lib/ReactInjection' ).Class.injectMixin
  • After: require( 'react/lib/ReactClass' ).injection.injectMixin

The react-tap-event-plugin package was similarly affected by shuffled internal lib paths and has been updated as part of this pull request (see changelog).

Testing instructions:

Verify that the application boots and runs without any issue, and that tests continue to pass.

cc @mtias @timmyc @ockham

@aduth aduth added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 21, 2016
@matticbot
Copy link
Contributor

@timmyc
Copy link
Contributor

timmyc commented Nov 21, 2016

No apparent improvements to the development console woes in Firefox, but in my testing of random aspects of Calypso, all seems to be working well for me. I tried to test out the areas changed in the branch like plugins list specifically.

@blowery
Copy link
Contributor

blowery commented Nov 21, 2016

My best recommendation if you need this is to build a component or similar completely in user space without depending on React internals. It should also be possible to fix up react-tap-event-plugin for v15, but we don't support that and can't guarantee that it will still work in a future release. source

Sigh.

@ockham
Copy link
Contributor

ockham commented Nov 21, 2016

Looks good, and tests well. Specifically, i18n still works, which seems the only actual change to production code that was required because of the ReactInjection.Class -> ReactClass.injection change.

Looking forward to this, since apparently it will make profiling React components easier!

@ockham ockham added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 21, 2016
@aduth aduth force-pushed the update/react-15-4-0 branch from b26328f to 89ac0c8 Compare November 22, 2016 16:20
@aduth aduth merged commit e3058c4 into master Nov 22, 2016
@aduth aduth deleted the update/react-15-4-0 branch November 22, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants