Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler color styles are not applied properly within Safari #89324

Closed
richtabor opened this issue Apr 8, 2024 · 1 comment · Fixed by #89381
Closed

Assembler color styles are not applied properly within Safari #89324

richtabor opened this issue Apr 8, 2024 · 1 comment · Fixed by #89381
Labels
[Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. [Type] Bug

Comments

@richtabor
Copy link

Steps to reproduce

  1. Open Safari
  2. Starting at URL: https://wordpress.com/setup/with-theme-assembler/pattern-assembler
  3. Add two patterns to the page.
  4. Select "Select styles"
  5. Select a premium style with a background color.

What I expected

To see the background color of the style applied to my patterns. It works as expected in Chrome.

What happened instead

The patterns maintain a background color of white, making it seem like the style is much less expressive and boring.

Browser / OS version

Safari, latest.

Screenshot / Video

CleanShot 2024-04-08 at 11 58 05

@richtabor richtabor added [Type] Bug [Feature] Pattern Assembler The tool for building off of blank canvas using patterns. labels Apr 8, 2024
@github-actions github-actions bot added the [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. label Apr 8, 2024
@taipeicoder
Copy link
Contributor

Sharing my findings below:

This issue is caused by a recent change in Gutenberg WordPress/gutenberg#59377 where the iframe body is explicitly set to have a white background. This was later fixed in WordPress/gutenberg#60106 where the CSS rule's specificity was reduced. Fixing this on Calypso side would require a version upgrade of the @wordpress/block-editor version from 12.22.0 to 12.23.0.

I've requested assistance from the Calypso team in #89343 (comment) for the package upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. [Type] Bug
2 participants