Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Search: Button and Label options can't be changed when part of Navigation Block #73860

Closed
Robertght opened this issue Feb 28, 2023 · 3 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. Navigation [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@Robertght
Copy link

Quick summary

If we have a Search block in a Navigation block, we cannot completely hide the button of the search from the template. It does hide on the frontend though.

Steps to reproduce

  1. From Appearance > Site Editor, choose a template with a header and a navigation block and make sure it has the Search block
  2. Select the search block and choose to not show any buttons.
  3. Save the changes

What you expected to happen

For the buttons to be hidden on the Site editor and frontend.

What actually happened

The buttons were removed from the editor temporarily(until it got refreshed) and permanently from the frontend.

Impact

Some (< 50%)

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

No response

Logs or notes

I tested this on a self-hosted website as well as on a WordPress.com website with two different themes(Rusell and Quadrat) and the results are the same.

Video: https://www.youtube.com/watch?v=30bkreFWOFI

Screenshot

8jobPv.png

Ticket: 5989070-zen

@github-actions github-actions bot added the [Pri] BLOCKER Requires immediate attention. label Feb 28, 2023
@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 5989070-zen

@cuemarie
Copy link

cuemarie commented Mar 12, 2023

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO

  • From my tests, it seems the issue here only is with the Search Block inside a Navigation block. There, giving the search block a label, or trying to change the button placement, is immediately reset in the editor.
  • By contrast, a search block placed directly onto the template in the same editor can have all settings saved as expected.

Self-Hosted Example

Screen.Capture.on.2023-03-11.at.20-12-04.mov

📌 ACTIONS

  • Marked as Triaged for Quality Squad review
  • Updated title

📌 Message to Author

  • @Robertght I'm not sure what you meant by we cannot completely hide the button of the search from the template. It does hide on the frontend though. Does this mean you were able to hide the button with CSS?

@cuemarie cuemarie changed the title Search block: Buttons settings aren't saving in the editor [Block] Search: Button and Label options can't be changed when part of Navigation Block Mar 12, 2023
@cuemarie cuemarie added [Pri] Normal Schedule for the next available opportuinity. Navigation Triaged To be used when issues have been triaged. [Feature] Full Site Editor The site editor. [Platform] Simple [Platform] Atomic labels Mar 12, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Mar 12, 2023
@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. and removed [Pri] BLOCKER Requires immediate attention. labels Mar 12, 2023
@annezazu
Copy link

I can't replicate this on WordPress.com:

search.button.mov

Nor could I with a self hosted site so I closed out the original report too and will be closing this out as well :)

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. Navigation [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants