Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is socket.io a devDependency? #589

Closed
tjwebb opened this issue Nov 24, 2015 · 2 comments
Closed

why is socket.io a devDependency? #589

tjwebb opened this issue Nov 24, 2015 · 2 comments

Comments

@tjwebb
Copy link

tjwebb commented Nov 24, 2015

https://github.com/Automattic/wp-calypso/blob/master/package.json#L127

It seems unlikely to me that this is correct

@Tug
Copy link
Contributor

Tug commented Nov 24, 2015

Socket.io is not used on WordPress.com in production, only in development for hot reloading of our modules bundled with Webpack.
If you are interested, I believe our integration is based on https://github.com/webpack/webpack-dev-server

@nb
Copy link
Member

nb commented Nov 24, 2015

We’re not using the server for the bundling in development, but the middleware.

As for socket.io, @Tug is right, it’s used in the hot reloading parts of the dev environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants