Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: no (clear?) way to rename or delete template parts #55372

Open
Nic-Sevic opened this issue Aug 11, 2021 · 5 comments
Open

FSE: no (clear?) way to rename or delete template parts #55372

Nic-Sevic opened this issue Aug 11, 2021 · 5 comments
Labels
Empathy Testing This tag is applied to bugs found when testing user flows. [Goal] Full Site Editing [Pri] Normal Triaged To be used when issues have been triaged. [Type] Enhancement User Report This issue was created following a WordPress customer report

Comments

@Nic-Sevic
Copy link
Contributor

Steps to Reproduce

  1. create a new template part
  2. go to templates menu and try to rename or delete
  3. Doesn't seem to be an option for either

What I expected to happen

You should be able to click on the template part and be able to edit it either in the editor or via a submenu

What actually happened

clicking the template part opens it for internal editing but I couldn't find a way to delete duplicate parts I created by accident or to rename them if I failed to name them on creation

2021-08-11 at 13 10

Context

empathy testing

Operating System

macOS

OS Version

No response

Browser

Chrome/Chromium

Browser Version(s)

No response

Is this specific to applied theme? If so, what is the theme name?

No response

Simple, Atomic or both?

No response

Console and/or error logs

No response

Number of Users Impacted

No response

Available Workarounds

No response

Reproducibility

No response

Other information

No response

@Nic-Sevic Nic-Sevic added [Type] Bug [Goal] Full Site Editing User Report This issue was created following a WordPress customer report Empathy Testing This tag is applied to bugs found when testing user flows. labels Aug 11, 2021
@jordesign jordesign added Triaged To be used when issues have been triaged. and removed [Type] Bug labels Aug 24, 2021
@jordesign
Copy link
Contributor

Template Parts can be edited/deleted/renamed directly from WP Admin - so I'm uncertain of the need to be able to do it from within the Site Editor.

@annezazu Is this something that is likely to differ between the Core implementation and what we do on WPCOM?

@annezazu
Copy link

I do not see a reason for why this would differ but would have to check with WPCOM product folks. For now, I do want to note one outstanding issue related to the name change properly propagating (that's the only issue I've found related to this): WordPress/gutenberg#29844

@jeyip
Copy link
Contributor

jeyip commented Nov 6, 2021

Renaming

It's possible to rename a template part through the block settings menu, although as @annezazu pointed out, the name change doesn't propagate throughout the UI without a page refresh.

2021-11-05 16 55 58

Something to note -- a template part block has to be selected in order for this option to appear in the block settings menu. This means that if we select a template part from the navigation sidebar and open the isolated template part view (as shown below), we won't be able to change the template part name.

2021-08-11 at 13 10

Deleting

As far as I know, template parts can only be deleted from the template parts list page accessible through the wp admin dashboard (Appearance > Template Parts).

@Addison-Stavlo I know you've worked a lot more with the template part flows than I have. These UI requests make sense to me, and it feels worthwhile to bring this up in core Gutenberg. Wondering if you have any thoughts on the matter.

@jeyip
Copy link
Contributor

jeyip commented Nov 8, 2021

These features have also been requested in the past.

#53320

@Addison-Stavlo
Copy link
Contributor

I think the interface is in a bit of redesign currently, so I don't have much of an opinion here. But the navigation sidebar noted above has recently been removed in core so this flow to manage template parts from it doesn't really exist in this form. There is an 'isolated' mode you can load a template part in, and the mentioned sidebar on the right seems like a logical place to have controls for that. There may be some contexts where deleting may or may not make sense and that control may have to be conditional. 🤷‍♀️

Im sure @jameskoster and other core designers have thought about this a bit more, and have a better idea where this may go in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Empathy Testing This tag is applied to bugs found when testing user flows. [Goal] Full Site Editing [Pri] Normal Triaged To be used when issues have been triaged. [Type] Enhancement User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

6 participants