-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing: Menu disappears when Publicize and Like buttons are disabled in Jetpack settings (AT sites) #20102
Comments
This is effectively another case of "implicit activation" being required. We should show the UI here regardless (unless force-disabled via code, cc @ebinnion ). Then if the user decides to use any of the features, we can/should activate the appropriate modules behind the scenes. |
@alaczek sounds good! |
This is very confusing. It's hard to tell if these settings are related to each other. I'm curious why these settings need to be enabled in Jetpack before they are displayed in Calypso? Are we not able to display these settings by default in Calypso? Publicize won't be enabled anyway until the user connects each of their social media accounts. And from my understanding, none of the Sharing buttons will appear too unless they explicitly select which pages they want them to appear on? In Calypso, "Connections" and "Sharing buttons" are separate tabs. Enabling the "Like" button is under "Sharing buttons". In Jetpack, enabling the Like button appears to be a separate card by itself and doesn't look to be related to the sharing buttons. I also noticed a bug where even though I do have "Publicize" and "Sharing buttons" enabled in Jetpack, the "Connections" and "Sharing buttons" tabs are not being displayed. But once I click the "Update" button from the sidebar, then click somewhere on the screen, they randomly show up: https://cloudup.com/ci06M75tzhh I would just display these settings in Calypso without the need for activation. However, if that isn't possible, as interim fixes to start, we could:
cc @jeffgolenski @alaczek @juliasydnor |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
👋 Hey folks! Since this issue has been inactive for quite some time, KitKat has made the decision to close it.
If you think this issue warrants another look, here are some next steps!
Thanks for your involvement! |
Steps to reproduce
What I expected
I expected "Sharing" to appear in the Calypso left menu.
What happened instead
"Sharing" is no longer visible in the Calypso left menu. All sharing settings can only be accessed via WP Admin > Jetpack > Settings > Sharing.
Browser / OS version
OS High Sierra 10.13.1
Chrome 62.0.3202.94
Screenshot / Video
JetPack settings: https://cloudup.com/c2JDbEn2GA2
Calypso menu: https://cloudup.com/cbniBz65nUl
Context / Source
Sharing buttons are still active, so users need to be able to easily access those settings from Calypso. Users should also be able to easily enable Publicize and Like buttons via Calypso, as normal, despite those settings being disabled in JetPack. It makes things confusing for users as they don't know the Sharing settings can be accessed via WP Admin, or where to even access them there.
#user-report
#manual-testing
The text was updated successfully, but these errors were encountered: