Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: MySitesSidebar missing :focus on links #1131

Closed
hoverduck opened this issue Dec 1, 2015 · 1 comment
Closed

Framework: MySitesSidebar missing :focus on links #1131

hoverduck opened this issue Dec 1, 2015 · 1 comment
Labels
Framework Good First Issue Small, contained issues. Navigation [Type] Bug When a feature is broken and / or not performing as intended

Comments

@hoverduck
Copy link
Contributor

Currently the sidebar is missing focus on links. This is really noticeable on mobile browsers when you tap on a link and you wonder if you actually clicked on it.

I think adding a focus state to links in the sidebar would fix this.

Having focus styles is good for usability, accessibility, and a general best practice. Not just for mobile users, but especially for any touch use case. Fully agree on this improvement.

I noticed the current-section navigation anchor — to go back to the previous screen, does have a hover style of sorts, which is helpful. A white background color change, at least, though it's pretty subtle.

image
@hoverduck hoverduck added [Type] Bug When a feature is broken and / or not performing as intended Framework Navigation labels Dec 1, 2015
@lancewillett lancewillett added the Good First Issue Small, contained issues. label Dec 4, 2015
@radnor radnor mentioned this issue Jan 7, 2016
Merged
@klimeryk
Copy link
Contributor

Fixed in #2173.

@ajesse11x ajesse11x mentioned this issue Nov 4, 2022
Open
@awaisab172 awaisab172 mentioned this issue Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this issue Dec 25, 2022
Open
@awaisab172 awaisab172 mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Good First Issue Small, contained issues. Navigation [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lancewillett @klimeryk @hoverduck