Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unit tests for restricting PM to location in client #7387

Closed
KarlisJ opened this issue Oct 5, 2023 · 1 comment · Fixed by #8945
Closed

Add missing unit tests for restricting PM to location in client #7387

KarlisJ opened this issue Oct 5, 2023 · 1 comment · Fixed by #8945
Assignees
@danielmx-dev
Labels
category: core WC Payments core related issues, where it’s obvious. component: checkout Issues related to Checkout focus: checkout payments good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@KarlisJ
Copy link
Contributor

KarlisJ commented Oct 5, 2023

Describe the bug

in #7315 we introduced 2 new JS methods that can be unit tested but we needed to land the changes in code freeze so PR was approved without the unit tests.

Expected behavior

The two new methods in client/checkout/utils/upe.js should be covered by unit tests.
@KarlisJ KarlisJ added type: enhancement The issue is a request for an enhancement. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. labels Oct 5, 2023
@KarlisJ KarlisJ self-assigned this Oct 5, 2023
@jessy-p jessy-p added the category: core WC Payments core related issues, where it’s obvious. label Oct 12, 2023
@haszari haszari added the focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). label Mar 11, 2024
@vbelolapotkov vbelolapotkov added component: checkout Issues related to Checkout focus: checkout payments and removed focus: misc or unknown Issues that need to be added to a focus area (aka "needs focus"). labels Apr 4, 2024
@pierorocca pierorocca added the priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. label Apr 21, 2024
@pierorocca pierorocca added type: technical debt This issue/PR represents/solves the technical debt of the project. and removed type: enhancement The issue is a request for an enhancement. labels May 15, 2024
@timur27
Copy link
Contributor

timur27 commented Jun 10, 2024

For visibility: this issue aims to address tests for two methods: isPaymentMethodRestrictedToLocation and togglePaymentMethodForCountry. The test suite for the latter was added in #8909, potentially requiring this issue to focus only on isPaymentMethodRestrictedToLocation.

@danielmx-dev danielmx-dev mentioned this issue Jun 12, 2024
Merged
6 tasks
@danielmx-dev danielmx-dev self-assigned this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmx-dev danielmx-dev

Labels
category: core WC Payments core related issues, where it’s obvious. component: checkout Issues related to Checkout focus: checkout payments good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev: Improve test coverage of upe.js Automattic/woocommerce-payments
7 participants
@vbelolapotkov @haszari @danielmx-dev @timur27 @KarlisJ @jessy-p @pierorocca