Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: add additional block-based footer layouts #5227

Closed
creativecoder opened this issue Dec 20, 2021 · 5 comments
Closed

Blockbase: add additional block-based footer layouts #5227

creativecoder opened this issue Dec 20, 2021 · 5 comments
Labels
Empathy Testing FSE Support Adding support for Full Site Editing to a theme [Pri] High [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Blockbase [Type] Enhancement New feature or request

Comments

@creativecoder
Copy link
Contributor

Blockbase has only one footer layout, and needs additional footer layouts.

When there are multiple options for a template part, the Template Part block toolbar will show a replace button, making it easy to replace the default layout with another one.

image

However, that interface doesn't show when only one layout is packaged with theme.

I saw users struggle to design a footer layout in the Site editor in recent testing. Most often, they seem to want to add additional columns to the footer.

What about adding 2-3 additional footer layouts with different column options? This would provide additional footer layout options for all our universal themes.

@creativecoder creativecoder added [Type] Enhancement New feature or request [Pri] High FSE Support Adding support for Full Site Editing to a theme [Theme] Blockbase Empathy Testing labels Dec 20, 2021
@MaggieCabrera
Copy link
Contributor

This is a good idea, I think we could bring Skatepark's footer to Blockbase too as a 3 column example. Keen to hear design ideas @kjellr and @beafialho

@kjellr
Copy link
Contributor

kjellr commented Jan 3, 2022

Yeah — we should add more. We can probably borrow from Twenty Twenty-Two as well. But I think they should actually be patterns, not template parts.

@creativecoder
Copy link
Contributor Author

But I think they should actually be patterns, not template parts.

For me, the important part is that the flow for changing the existing template part is easily discoverable, like the screenshot with the replace button in the issue description. I don't think patterns get us that discoverability right now, but I haven't tested.

@kjellr
Copy link
Contributor

kjellr commented Jan 12, 2022

Yeah, pattern discovery at the moment is limited. But there are already explorations to try and improve that: WordPress/gutenberg#31747 (comment)

@MaggieCabrera MaggieCabrera added [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. and removed design labels Apr 12, 2022
@MaggieCabrera
Copy link
Contributor

I'm closing this one since we already included multiple footers and headers for Blockbase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Empathy Testing FSE Support Adding support for Full Site Editing to a theme [Pri] High [Status] Needs Design Approval This task needs a designer to approve the changes before it can be merged or marked complete. [Theme] Blockbase [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants