Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mayland Blocks: Distorted images #3635

Closed
alaczek opened this issue Apr 9, 2021 · 6 comments
Closed

Mayland Blocks: Distorted images #3635

alaczek opened this issue Apr 9, 2021 · 6 comments

Comments

@alaczek
Copy link
Contributor

alaczek commented Apr 9, 2021

The issue previously reported in #3382 has resurfaced again. This might be related to making it a child theme of Blank Canvas Blocks.

Steps to replicate

  1. Create a site with Full Site Editing and Mayland Blocks active.
  2. Open the site editor and add an Image block into the post content (upload new, select from the media library, or from Pexels).
  3. Save and preview the site in a new tab. Note the image is distorted.

You can see the issue live on https://maylandblockstarter.wordpress.com/

@jffng
Copy link
Contributor

jffng commented Apr 9, 2021

I just tried to replicate by creating a new site, and the images appear correctly with the reset styles (which were not removed in the recent update).

Site Editor Front end
Screen Shot 2021-04-08 at 11 00 32 PM Screen Shot 2021-04-08 at 11 01 10 PM

You can see the issue live on PcTiN4-f-p2

It appears that the maylandblockstarter site is not loading the stylesheet at all.

We declare a dependency blank_canvas_blocks-ponyfill to load the stylesheet, but I do not know why it would impact that starter site differently.

@jffng jffng added this to the Mayland Blocks milestone Apr 9, 2021
@jffng
Copy link
Contributor

jffng commented Apr 9, 2021

The issue has resolved on the starter site, so going to close this. Please re-open if it comes up again!

Screen Shot 2021-04-09 at 9 25 27 AM

@jffng jffng closed this as completed Apr 9, 2021
@alaczek
Copy link
Contributor Author

alaczek commented Apr 11, 2021

I just switched themes to Blank Canvas Blocks and back to Mayland Blocks again. That seems to have cleared up the distorted images issue. But I noticed something else - there is no spacing added when content is wrapped in a group block with background set. Was that something special added in Varia themes?

@alaczek
Copy link
Contributor Author

alaczek commented Apr 11, 2021

🤦‍♀️ I forgot we have padding controls for that now :)

@alaczek
Copy link
Contributor Author

alaczek commented Aug 31, 2021

I wanted to reopen this issue as it's happening again. I was just updating Mayland Blocks demo and starter sites to use Columns + Images instead of Coblocks Masonry Gallery, and this is what I'm seeing:

image

@alaczek alaczek reopened this Aug 31, 2021
@MaggieCabrera
Copy link
Contributor

The demo site for Mayland blocks was not loading the theme correctly. I don't know about the started one, but after changing themes and going back to Mayland blocks, it fixed the image issue and some other problems that the site had. I'm closing this, feel free to reopen if it's still happening to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants