From 72768e17529ddf25f07204cd4fb67f0708c693f9 Mon Sep 17 00:00:00 2001 From: Jason Crist Date: Fri, 20 Aug 2021 11:50:17 -0400 Subject: [PATCH 1/2] Removed unneeded styles on links/site-title to allow globally configured values to filter through correctly. --- seedlet-blocks/assets/theme.css | 19 ++++++------------- seedlet-blocks/sass/blocks/_links.scss | 11 ++--------- seedlet-blocks/sass/blocks/_site-title.scss | 2 -- 3 files changed, 8 insertions(+), 24 deletions(-) diff --git a/seedlet-blocks/assets/theme.css b/seedlet-blocks/assets/theme.css index 9b7ac09a70..4ffa4cd2a9 100644 --- a/seedlet-blocks/assets/theme.css +++ b/seedlet-blocks/assets/theme.css @@ -140,28 +140,23 @@ /** * Links in navigation */ +.wp-block-navigation-link a { + text-underline-offset: 0.4rem; +} + .wp-block-navigation-link a :hover { text-decoration: underline; - text-underline-offset: 0.4rem; } /** * Links in Content */ -.is-root-container a:not(.wp-block-button__link):not([download]), -.wp-block-post-content a:not(.wp-block-button__link):not([download]) { - color: var(--wp--custom--color--primary); - text-decoration-color: var(--wp--style--color--link); +.is-root-container a, +.wp-block-post-content a { text-decoration-thickness: 1px; text-underline-offset: 0.2em; } -.is-root-container a:not(.wp-block-button__link):not([download]):focus, .is-root-container a:not(.wp-block-button__link):not([download]):hover, -.wp-block-post-content a:not(.wp-block-button__link):not([download]):focus, -.wp-block-post-content a:not(.wp-block-button__link):not([download]):hover { - color: var(--wp--style--color--link); -} - .wp-block-navigation__responsive-container.has-modal-open .wp-block-navigation-link { font-family: var(--wp--preset--font-family--headings); font-size: 32px; @@ -291,9 +286,7 @@ is passed all of the block attributes on the block definition in the template. * .wp-block-site-title a { text-decoration: underline; text-decoration-thickness: 2px; - text-decoration-color: var(--wp--custom--color--secondary); text-underline-offset: 0.13em; - transition: background-size 0.1s ease-out; } .wp-block-site-title a:hover, .wp-block-site-title a:focus { diff --git a/seedlet-blocks/sass/blocks/_links.scss b/seedlet-blocks/sass/blocks/_links.scss index 3d53423340..a0175f9118 100644 --- a/seedlet-blocks/sass/blocks/_links.scss +++ b/seedlet-blocks/sass/blocks/_links.scss @@ -3,9 +3,9 @@ */ .wp-block-navigation-link { a { + text-underline-offset: 0.4rem; :hover{ text-decoration: underline; - text-underline-offset: 0.4rem; } } } @@ -15,15 +15,8 @@ */ .is-root-container, // Editor class hack. .wp-block-post-content { - a:not(.wp-block-button__link):not([download]) { - color: var(--wp--custom--color--primary); - text-decoration-color: var(--wp--style--color--link); + a { text-decoration-thickness: 1px; text-underline-offset: 0.2em; - - &:focus, - &:hover { - color: var(--wp--style--color--link); - } } } \ No newline at end of file diff --git a/seedlet-blocks/sass/blocks/_site-title.scss b/seedlet-blocks/sass/blocks/_site-title.scss index 066f14c14c..04af8e9690 100644 --- a/seedlet-blocks/sass/blocks/_site-title.scss +++ b/seedlet-blocks/sass/blocks/_site-title.scss @@ -3,9 +3,7 @@ a { text-decoration: underline; text-decoration-thickness: 2px; - text-decoration-color: var(--wp--custom--color--secondary); text-underline-offset: 0.13em; - transition: background-size 0.1s ease-out; &:hover, &:focus { From 257494b6a45b0a323cb6cbd10ce27c9e67b3fe84 Mon Sep 17 00:00:00 2001 From: Jeremy Yip Date: Mon, 23 Aug 2021 10:57:10 -0700 Subject: [PATCH 2/2] Remove unnecessary site title hover state styling --- seedlet-blocks/assets/theme.css | 1 - seedlet-blocks/sass/blocks/_site-title.scss | 1 - 2 files changed, 2 deletions(-) diff --git a/seedlet-blocks/assets/theme.css b/seedlet-blocks/assets/theme.css index 4ffa4cd2a9..6f0f489aac 100644 --- a/seedlet-blocks/assets/theme.css +++ b/seedlet-blocks/assets/theme.css @@ -291,7 +291,6 @@ is passed all of the block attributes on the block definition in the template. * .wp-block-site-title a:hover, .wp-block-site-title a:focus { text-decoration: none; - color: var(--wp--custom--color--secondary); background-size: 8px 0px; } diff --git a/seedlet-blocks/sass/blocks/_site-title.scss b/seedlet-blocks/sass/blocks/_site-title.scss index 04af8e9690..bfd68d1877 100644 --- a/seedlet-blocks/sass/blocks/_site-title.scss +++ b/seedlet-blocks/sass/blocks/_site-title.scss @@ -8,7 +8,6 @@ &:hover, &:focus { text-decoration: none; - color: var(--wp--custom--color--secondary); background-size: 8px 0px; }