Labeling and shortcut errors in menus

[mirka]

There are some errors in the menus that make the app feel less native.

Most of these can be fixed by adding the correct role and/or removing the label where unnecessary, as Electron has a lot of the logic built in.

We should probably do some refactoring to allow easier per-platform logic based on composition, since we will be adding more menu items. The current system is quite error-prone and is bloating the app.js file.

all

• accelerator for “Font Size ▸ Bigger” should be CommandOrControl+Plus instead of CommandOrControl+= (Quirk seems to be fixed now) (adjusted menu to display zoom at view root level #863)
• Multi-step items (“Preferences”, “Export Notes”, “Print”, “Search Notes”) should have an ellipsis … appended

darwin

• Shortcut for “Hide Others” should be Cmd+Opt+H
• “Hide” and “Quit” should be suffixed by app name
• Help menu should include searchable field (can be achieved by adding role: 'help')
• “Bring All to Front” is in the wrong menu ([macOS] Put “Bring All to Front” in proper menu #813)

linux

• “Exit” should be “Quit”
• Window menu should not exist
• Help / Help & Support is duplicated

win32

• Shortcut for “Redo” should be Ctrl+Y
• Window menu should not exist

[rakhi2104]

Shortcut for “Redo” should be Ctrl+Y

is it applicable only to Windows ?

[mirka]

Shortcut for “Redo” should be Ctrl+Y

is it applicable only to Windows ?

Yes, and I think removing the explicit accelerator property and using just role: 'redo' would work, because the logic is baked into Electron. We are actually overwriting the platform logic by adding an accelerator ourselves 😅

[rakhi2104]

Updating those changes @mirka.
Thanks for reviewing

[rakhi2104]

Most of the edit commands already have role assigned in the code.
Is accelerator overriding them ?

[mirka]

Most of the edit commands already have role assigned in the code.
Is accelerator overriding them ?

That's correct. So my plan was to look at the Electron code for menu item roles, and remove any properties from our code that is unnecessary.

We still have to override the labels though, because the default labels don't include Windows access keys. (That's what the ampersands in the labels are)