Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New revision slider should not cover tags area #2654

Closed
pachlava opened this issue Feb 10, 2021 · 4 comments · Fixed by #2817
Closed

New revision slider should not cover tags area #2654

pachlava opened this issue Feb 10, 2021 · 4 comments · Fixed by #2817
Assignees
Labels
feature request Request for a new feature [feature] tags Anything related to tags. NewMember

Comments

@pachlava
Copy link
Contributor

What

Since changes in tags is a part of a note history, it makes sense to have tags area visible while browsing the revisions.

Why

When the tags area is covered by history overlay, it's impossible to see the changes in tags.

How

Make tags area appear above revisions panel

@belcherj
Copy link
Contributor

belcherj commented Mar 1, 2021

Check with @SylvesterWilmott on this one.

@fluiddot
Copy link
Contributor

When the note history is opened, the content of the note is previewed but it doesn't include the tags. One way to solve this would be to render the tags of the revision in a new component at the bottom of the content, similar to what is displayed when editing.

@SylvesterWilmott
Copy link
Contributor

@fluiddot From the point of view of the user, the history panel would push up all of the editor content including the tags input field?

@fluiddot
Copy link
Contributor

fluiddot commented Mar 31, 2021

@fluiddot From the point of view of the user, the history panel would push up all of the editor content including the tags input field?

Yeah, although the tags won't be interactive. I created a PR with a potential solution and here you can see how it looks like:

tags-history.mp4

Let me know @SylvesterWilmott what you think about this option, thanks 🙇 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature [feature] tags Anything related to tags. NewMember
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants