Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Courses: Custom content width in Learning Mode template is not applied to lessons #7716

Open
dericleeyy opened this issue Dec 4, 2024 · 5 comments
Open

Courses: Custom content width in Learning Mode template is not applied to lessons #7716

dericleeyy opened this issue Dec 4, 2024 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Low Cosmetic issue, low impact, easy workaround [Type] Bug

Comments

@dericleeyy
Copy link

dericleeyy commented Dec 4, 2024 •
edited by supernovia
Loading

Steps to Reproduce

  1. Edit the learning mode template
  2. Click on Content Block in Main Content
  3. Set a custom content width
  4. Save
  5. View a lesson

What I Expected

The lessons to follow the custom content width set

What Happened Instead

When viewing a lesson, the styling is followed at first, but it reloads and resets the content width to fill up the entire screen

PHP / WordPress / Sensei LMS version

WP 6.7.1
Sensei 4.24.4

Screenshot / Video

Image
Image

Context / Source

9121185-zen
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 9121185-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 4, 2024
@donnapep
Copy link
Collaborator

donnapep commented Dec 4, 2024 •
edited
Loading

@dericleeyy Could you please add the theme you were using as it may be relevant? 🙇‍♀ From the ticket, looks like it's the Course theme. Moving to the themes repo.

@donnapep donnapep transferred this issue from Automattic/sensei Dec 4, 2024
@supernovia
Copy link

supernovia commented Dec 4, 2024 •
edited
Loading

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
The site's main content width overrides anything set in the template
https://github.com/user-attachments/assets/0c719f4d-8f67-4e9e-aa28-140515faa5b6

📌 ACTIONS

  • Triaged & prioritized
  • Clarified title and added a step to make it easier to reproduce

@supernovia supernovia added the [Pri] Low Cosmetic issue, low impact, easy workaround label Dec 4, 2024
@supernovia supernovia changed the title Customizing Content Width in Learning Mode template does not work Courses: Custom content width in Learning Mode template is not applied to lessons Dec 4, 2024
@dericleeyy
Copy link
Author

dericleeyy commented Dec 5, 2024 •
edited
Loading

@donnapep I don't think this is theme-dependent. I reproduced it on the Twenty Twenty-Four theme.

I suspect this has something to do with the reactivity of the content to the width of the browser.

@donnapep
Copy link
Collaborator

Confirmed. Moving back to Sensei.

@donnapep donnapep transferred this issue from Automattic/themes Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] Low Cosmetic issue, low impact, easy workaround [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@donnapep @supernovia @dericleeyy