Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block themes should inherit their own styles in Learning Mode #7449

Open
donnapep opened this issue Jan 24, 2024 · 0 comments
Open

Block themes should inherit their own styles in Learning Mode #7449

donnapep opened this issue Jan 24, 2024 · 0 comments
Labels
Learning Mode [Pri] Low Cosmetic issue, low impact, easy workaround [Status] Needs Triage Issue needs to be triaged [Type] Enhancement

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jan 24, 2024

Is your feature request related to a problem? Please describe

When using a block theme other than Course, the Learning Mode styles are overridden to ensure that LM looks (mostly) the same across all themes. Perhaps we shouldn't be this opinionated, and should inherit from the block theme's styles instead. (This may be worth further discussion, as it will impact existing sites.)

Describe the solution you'd like

Don't override block themes' styles in Learning Mode. The only styles that should be overridden are those of non-block themes like Divi and Astra.

Consideration: Should we only do this for new installs? Because otherwise the look & feel of Learning Mode will suddenly change on sites using block themes, and perhaps not for the better.

Also, we probably shouldn't do this until the other issues with global styles and styles in general in Learning Mode are resolved.

@donnapep donnapep added [Type] Enhancement [Pri] Normal Can wait for the next release Learning Mode [Status] Triaged Issue has been triaged labels Jan 24, 2024
@donnapep donnapep added [Pri] Low Cosmetic issue, low impact, easy workaround [Status] Triaged Issue has been triaged and removed [Status] Triaged Issue has been triaged [Pri] Normal Can wait for the next release labels Feb 26, 2024
@donnapep donnapep added [Status] Needs Triage Issue needs to be triaged and removed [Status] Triaged Issue has been triaged labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Learning Mode [Pri] Low Cosmetic issue, low impact, easy workaround [Status] Needs Triage Issue needs to be triaged [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant