Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email editor is broken when latest Gutenberg is on #7262

Closed
Imran92 opened this issue Nov 3, 2023 · 5 comments
Closed

Email editor is broken when latest Gutenberg is on #7262

Imran92 opened this issue Nov 3, 2023 · 5 comments
Assignees
Labels
Milestone

Comments

@Imran92
Copy link
Contributor

Imran92 commented Nov 3, 2023

Steps to Reproduce

  1. Make sure you have the latest Gutenberg on.
  2. Go to Sensei LMS -> Settings -> Emails
  3. Click on any email to open it in editor

What I Expected

To see the email in the editor.

What Happened Instead

It was broken

PHP / WordPress / Sensei LMS version

8.1, 6.3, 4.19

Browser / OS version

Chrome, Opera

Screenshot / Video

With GB

Screenshot 2023-11-03 at 2 18 58 PM

Without GB

Screenshot 2023-11-03 at 2 20 16 PM

I'm not too sure, but after looking around a bit, it looks like there may be something wrong with the wp:pattern markup

@renatho
Copy link
Contributor

renatho commented Nov 3, 2023

I think your assumption is correct about the patterns. I noticed the same thing on Course and Lesson editor and reported here for now: p1698850222584179-slack-C45SNKV4Z. I'll try to reported in some other places to see if we can get some priority in this fix.

@renatho
Copy link
Contributor

renatho commented Nov 3, 2023

I submitted a PR to fix it directly on Gutenberg: WordPress/gutenberg#55858. Hopefully, it will be merged before the final release of WP 6.4! 🙏

@renatho renatho self-assigned this Nov 3, 2023
@donnapep
Copy link
Collaborator

donnapep commented Nov 4, 2023

📌 REPRODUCTION RESULTS
– Tested on Self-Hosted – Replicated
– Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Reproduced for courses and lessons as well.
  • The impact for courses and lessons is less severe though, as exiting the modal or selecting a pattern restores the editor.

Screenshot 2023-11-04 at 10 05 26 AM

@donnapep donnapep added [Pri] High Ship ASAP [Status] Triaged Issue has been triaged labels Nov 4, 2023
@donnapep donnapep added this to the 4.19.1 milestone Nov 4, 2023
@donnapep donnapep added the Emails label Nov 4, 2023
@donnapep
Copy link
Collaborator

donnapep commented Nov 4, 2023

Hopefully, it will be merged before the final release of WP 6.4!

@renatho If it's not, is there anything we can do in Sensei to mitigate it?

@renatho
Copy link
Contributor

renatho commented Nov 5, 2023

Hopefully, it will be merged before the final release of WP 6.4!

@renatho If it's not, is there anything we can do in Sensei to mitigate it?

@donnapep, It was merged already and will be part of the final 6.4 release! 🙌
So I'm closing this issue!

@renatho renatho closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants